Re: [PATCH] BUG: http: do not abort keep-alive connections on server timeout

2015-11-13 Thread Laurent Senta
Here you go, sorry about that. On Fri, Nov 13, 2015 at 2:18 PM Willy Tarreau wrote: > Hi Laurent, > > thanks for this. However as you can see, your mailer has completely > mangled the patch : > > > diff --git a/src/proto_http.c b/src/proto_http.c > > index 2dcac06..d33b4a1 100644 > > --- a/src/p

Re: HAProxy does not write 504 on keep-alive connections

2015-11-13 Thread Laurent Senta
Done! Thanks a lot Willy, On Thu, Nov 12, 2015 at 8:26 PM Willy Tarreau wrote: > Hi Laurent, > > On Thu, Nov 12, 2015 at 06:44:42PM +, Laurent Senta wrote: > > > > > > > > > > I traced back that change to: > > > > > >

[PATCH] BUG: http: do not abort keep-alive connections on server timeout

2015-11-13 Thread Laurent Senta
When a server timeout is detected on the second or nth request of a keep-alive connection, HAProxy closes the connection without writing a response. Some clients would fail with a remote disconnected exception and some others would retry potentially unsafe requests. This patch removes the special

Re: HAProxy does not write 504 on keep-alive connections

2015-11-12 Thread Laurent Senta
> > > > I traced back that change to: > > > http://git.haproxy.org/?p=haproxy-1.6.git;a=commit;h=6b726adb35d998eb55671c0d98ef889cb9fd64ab > > > > I don't understand why it's saner to kill the connection and hide the 504 > > instead of clearly stating the error and let the application handle the > >

Re: HAProxy does not write 504 on keep-alive connections

2015-11-10 Thread Laurent Senta
idge wrote: > On Tue, Nov 10, 2015 at 7:32 PM, Bryan Talbot > wrote: > > On Tue, Nov 10, 2015 at 12:04 PM, Laurent Senta > > > wrote: > >> > >> Hi there, > >> I think there's a bug in how HAProxy handles timeout, that'd be great if > &g

HAProxy does not write 504 on keep-alive connections

2015-11-10 Thread Laurent Senta
Hi there, I think there's a bug in how HAProxy handles timeout, that'd be great if you can confirm or help me figure out what I do wrong: Basically: if a server timeout happens on a keep-alive connection, haproxy does not write a 504 response before closing the socket. This leads python to fail w