Re: [RFC][PATCHES] seamless reload

2017-04-12 Thread Steven Davidovitz
I had a problem testing it on Mac OS X, because cmsghdr is aligned to 4 bytes. I changed the CMSG_ALIGN(sizeof(struct cmsghdr)) call to CMSG_LEN(0) to fix it. On Wed, Apr 12, 2017 at 10:41 AM, Olivier Houchard wrote: > Yet another patch, on top of the previous ones. >

[PATCH] BUILD: fix for non-transparent builds

2017-04-06 Thread Steven Davidovitz
Broke in dba9707713eb49a39b218f331c252fb09494c566. --- src/server.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/server.c b/src/server.c index 23343d86..536bf853 100644 --- a/src/server.c +++ b/src/server.c @@ -1742,12 +1742,14 @@ int parse_server(const char *file, int linenum, char

Re: [RFC PATCH] MEDIUM: persistent connections for SSL checks

2017-03-15 Thread Steven Davidovitz
Thank you! I may one day follow-up on persistent connections, but this does this trick for now. On Wed, Mar 15, 2017 at 3:44 AM, Willy Tarreau wrote: > On Mon, Mar 13, 2017 at 06:10:23PM +0100, Willy Tarreau wrote: > > > Just wanted to follow up. I've been running this patch for a

Re: [RFC PATCH] MEDIUM: persistent connections for SSL checks

2017-03-13 Thread Steven Davidovitz
Hi, Just wanted to follow up. I've been running this patch for a couple days on an idle system and haven't noticed any problems. Could this be merged? Is there anything else I can test? On Wed, Mar 8, 2017 at 1:22 PM, Steven Davidovitz <ste...@squareup.com> wrote: > Looks like just a

Re: [RFC PATCH] MEDIUM: persistent connections for SSL checks

2017-03-08 Thread Steven Davidovitz
t;w...@1wt.eu> wrote: > On Tue, Mar 07, 2017 at 12:27:38PM -0800, Steven Davidovitz wrote: > > I tried on 1.8dev and was still able to reproduce the problem. > > It appears Java is strictly interpreting the TLS spec with regards to > > "Closure Alerts". > >

Re: [RFC PATCH] MEDIUM: persistent connections for SSL checks

2017-03-07 Thread Steven Davidovitz
drain(conn); + conn_data_shutw(conn); conn_force_close(conn); } On Mon, Mar 6, 2017 at 10:48 PM, Willy Tarreau <w...@1wt.eu> wrote: > On Mon, Mar 06, 2017 at 06:34:09PM -0800, Steven Davidovitz wrote: > > Interestingly, as far as I can tell, we are

Re: [RFC PATCH] MEDIUM: persistent connections for SSL checks

2017-03-06 Thread Steven Davidovitz
Thanks for the response! On Mon, Mar 6, 2017 at 1:34 AM, Willy Tarreau wrote: > > [snip] > > Also it is not normal at all that SSL checks lead to CPU saturation. > Normally, health checks are expected to store the last SSL_CTX in the > server struct for later reuse, leading to a

[RFC PATCH] MEDIUM: persistent connections for SSL checks

2017-03-01 Thread Steven Davidovitz
Thanks! Steven Davidovitz include/types/checks.h | 1 + src/checks.c | 96 +- 2 files changed, 57 insertions(+), 40 deletions(-) diff --git a/include/types/checks.h b/include/types/checks.h index 283ff3db..0e86a741 100644 ---