Re: [PATCH] BUG/MEDIUM: namespace: close open namespaces during soft shutdown

2019-09-25 Thread kkovacs
Hi Willy, Willy Tarreau writes: > Hi Krisztián, > > On Tue, Sep 24, 2019 at 12:18:51PM +, Krisztián Kovács (kkovacs) wrote: >> When doing a soft shutdown, we won't be making new connections anymore so >> there's no point in keeping the namespace file des

[PATCH] BUG/MEDIUM: namespace: close open namespaces during soft shutdown

2019-09-24 Thread kkovacs
When doing a soft shutdown, we won't be making new connections anymore so there's no point in keeping the namespace file descriptors open anymore. Keeping these open effectively makes it impossible to properly clean up namespaces which are no longer used in the new configuration until all

[PATCH] BUG/MEDIUM: namespace: fix fd leak in master-worker mode

2019-09-20 Thread kkovacs
When namespaces are used in the configuration, the respective namespace handles are opened during config parsing and stored in an ebtree for lookup later. Unfortunately, when the master process re-execs itself these file descriptors were not closed, effectively leaking the fds and preventing