Re: [PATCH 3/3] BUG/MINOR: haproxy: Free rule->arg.vars.expr during deinit_act_rules

2020-06-14 Thread Tim Düsterhus
William, Am 14.06.20 um 16:59 schrieb Tim Düsterhus: > I can reproduce this with the following config: > > frontend http > mode http > bind 127.0.0.1:80 > > http-request redirect scheme https if METH_GET > >> $ valgrind ./haproxy -c -f ./crasher.cfg >> [...] >> ==6484== Invalid

Re: [PATCH 3/3] BUG/MINOR: haproxy: Free rule->arg.vars.expr during deinit_act_rules

2020-06-14 Thread Tim Düsterhus
William, Am 14.06.20 um 16:28 schrieb William Dauchy: > After this patch, I'm getting a segfault after firing an USR1 signal > to trigger the deinit: > > #0 0x55b653aaec34 in release_sample_expr (expr=0x55b654766bc0) at > src/sample.c:1427 > b1427

Re: [PATCH 3/3] BUG/MINOR: haproxy: Free rule->arg.vars.expr during deinit_act_rules

2020-06-14 Thread William Dauchy
Hello, On Sun, Jun 14, 2020 at 7:40 AM Willy Tarreau wrote: > On Sun, Jun 14, 2020 at 12:37:43AM +0200, Tim Duesterhus wrote: > > careful with this one: I don't know whether it's safe to simply free the > > expression there or whether I need to somehow check whether there actually > > is some

Re: [PATCH 3/3] BUG/MINOR: haproxy: Free rule->arg.vars.expr during deinit_act_rules

2020-06-13 Thread Willy Tarreau
Hi Tim, On Sun, Jun 14, 2020 at 12:37:43AM +0200, Tim Duesterhus wrote: > Willy, > > careful with this one: I don't know whether it's safe to simply free the > expression there or whether I need to somehow check whether there actually > is some expression. > > It does not crash with my stupid