Re: SRV records resolution failure if Authority section is present

2020-07-29 Thread Willy Tarreau
Patch applied, thanks guys! Willy

Re: SRV records resolution failure if Authority section is present

2020-07-28 Thread Baptiste
On Tue, Jul 28, 2020 at 2:59 PM Jerome Magnin wrote: > Hi, > > On Sun, Jul 26, 2020 at 10:41:18PM +0200, Willy Tarreau wrote: > > Thanks Jérôme, > > > > CCing Baptiste for approval (in case we've missed anything, I'm clueless > > about DNS). > > > > Baptiste just reviewed my patch, made a couple

Re: SRV records resolution failure if Authority section is present

2020-07-28 Thread Jerome Magnin
Hi, On Sun, Jul 26, 2020 at 10:41:18PM +0200, Willy Tarreau wrote: > Thanks Jérôme, > > CCing Baptiste for approval (in case we've missed anything, I'm clueless > about DNS). > Baptiste just reviewed my patch, made a couple suggestions, so please find an update attached to this email. >From

Re: SRV records resolution failure if Authority section is present

2020-07-26 Thread Willy Tarreau
Thanks Jérôme, CCing Baptiste for approval (in case we've missed anything, I'm clueless about DNS). Willy On Sun, Jul 26, 2020 at 06:04:38PM +0200, Jerome Magnin wrote: > Hi Tim, > > On Sun, Jul 26, 2020 at 05:47:00PM +0200, Tim Düsterhus wrote: > > Jerome, > > > > Regarding the commit

Re: SRV records resolution failure if Authority section is present

2020-07-26 Thread Jerome Magnin
Hi Tim, On Sun, Jul 26, 2020 at 05:47:00PM +0200, Tim Düsterhus wrote: > Jerome, > > Regarding the commit message: Please add backporting information to the > end of the commit message body (I believe it should be 2.2+). You're right the commit I mentionned in the message was indeed introduced

Re: SRV records resolution failure if Authority section is present

2020-07-26 Thread Tim Düsterhus
Jerome, Am 26.07.20 um 17:25 schrieb Jerome Magnin: > Please find a proper fix attached. We already know if we have entries in > the Authority section (dns_p->header.nscount > 0), so just skip them > when they are present and only use the Additional records. Regarding the commit message: Please

SRV records resolution failure if Authority section is present

2020-07-26 Thread Jerome Magnin
On Sun, Jul 26, 2020 at 01:21:45PM +0200, Jerome Magnin wrote: > as I was trying to reproduce the issue with DNS Service Discovery with > SRV records reported in issue #775 I encountered a different issue. > > I am using bind as a dns server, and its answers contain an Authority > field before