Re: v1.9.x segfault on LIST_DEL(>wait_queue)
Hi William, On Wed, Apr 17, 2019 at 07:29:49AM +, William Dauchy wrote: > Hello Willy, > > On Thu, Apr 11, 2019 at 11:34:52AM +0200, Willy Tarreau wrote: > > With this said, we've got no negative feedback on the patch above after > > one month and a half, which likely is a good indication that we should > > now backport it (carefully as mentionned in the commit message). > > Based on last HEAD from haproxy-1.9 tree, we no longer have those > regular segfault. Excellent, thank you for the feedback. Willy
Re: v1.9.x segfault on LIST_DEL(>wait_queue)
Hello Willy, On Thu, Apr 11, 2019 at 11:34:52AM +0200, Willy Tarreau wrote: > With this said, we've got no negative feedback on the patch above after > one month and a half, which likely is a good indication that we should > now backport it (carefully as mentionned in the commit message). Based on last HEAD from haproxy-1.9 tree, we no longer have those regular segfault. Thanks for the backport work! -- William
Re: v1.9.x segfault on LIST_DEL(>wait_queue)
Hi Willy, On Thu, Apr 11, 2019 at 11:34:52AM +0200, Willy Tarreau wrote: > Unfortunately this one looks different. It dies when it is stopping > (see deinit, unbind*, ...), are you sure it's not the previous process > when you're performing a reload ? Note that it *could* possibly still > be the same, but I find it strange that it only dies on exit and that > surprisingly the process quits with saturated listeners. Indeed, I realised my description was misleading. I mixed the time when the machine is booting with an older config, and then gets updates which is being reloaded just after. So it's indeed a reload. > With this said, we've got no negative feedback on the patch above after > one month and a half, which likely is a good indication that we should > now backport it (carefully as mentionned in the commit message). let us know if you need some hands for the backport, we may try to propose it. Thanks, -- William
Re: v1.9.x segfault on LIST_DEL(>wait_queue)
Hi William, On Wed, Apr 10, 2019 at 06:00:28PM +, William Dauchy wrote: > Hello, > > We are seeing a quite regular segfault when haproxy v1.9 joins our cluster > and almost immediately crash with: > > #0 0x55b66f75c825 in do_unbind_listener > (listener=listener@entry=0x55b67206dcb0, do_close=do_close@entry=1) at > src/listener.c:328 > 328 LIST_DEL(>wait_queue); > #1 0x55b66f75cf02 in unbind_listener > (listener=listener@entry=0x55b67206dcb0) at src/listener.c:351 > #2 0x55b66f75cfb8 in unbind_all_listeners (proto=0x55b66fa16300 > ) at src/listener.c:374 > #3 0x55b66f7a2e7e in protocol_unbind_all () at src/protocol.c:76 > #4 0x55b66f6ff5d0 in deinit () at src/haproxy.c:2548 > #5 0x55b66f67732d in main (argc=, argv=0x7ffe16c546b8) at > src/haproxy.c:3366 > > The code in mainline has changed since commit > http://git.haproxy.org/?p=haproxy.git;a=commit;h=01abd025084b4fe50e84189d1a83499cbf4825ed > which stated "This patch must carefully be backported to 1.9" > > Do you have any status about it? Unfortunately this one looks different. It dies when it is stopping (see deinit, unbind*, ...), are you sure it's not the previous process when you're performing a reload ? Note that it *could* possibly still be the same, but I find it strange that it only dies on exit and that surprisingly the process quits with saturated listeners. With this said, we've got no negative feedback on the patch above after one month and a half, which likely is a good indication that we should now backport it (carefully as mentionned in the commit message). Thanks, Willy
v1.9.x segfault on LIST_DEL(>wait_queue)
Hello, We are seeing a quite regular segfault when haproxy v1.9 joins our cluster and almost immediately crash with: #0 0x55b66f75c825 in do_unbind_listener (listener=listener@entry=0x55b67206dcb0, do_close=do_close@entry=1) at src/listener.c:328 328 LIST_DEL(>wait_queue); #1 0x55b66f75cf02 in unbind_listener (listener=listener@entry=0x55b67206dcb0) at src/listener.c:351 #2 0x55b66f75cfb8 in unbind_all_listeners (proto=0x55b66fa16300 ) at src/listener.c:374 #3 0x55b66f7a2e7e in protocol_unbind_all () at src/protocol.c:76 #4 0x55b66f6ff5d0 in deinit () at src/haproxy.c:2548 #5 0x55b66f67732d in main (argc=, argv=0x7ffe16c546b8) at src/haproxy.c:3366 The code in mainline has changed since commit http://git.haproxy.org/?p=haproxy.git;a=commit;h=01abd025084b4fe50e84189d1a83499cbf4825ed which stated "This patch must carefully be backported to 1.9" Do you have any status about it? Thanks, -- William
