Hi Willy,
On 2014/12/18 0:07, Willy Tarreau wrote:
Hi Godbach,
On Wed, Dec 17, 2014 at 04:41:33PM +0800, Godbach wrote:
From 798d50b1922e9680ea69cbc39d54f20665c782da Mon Sep 17 00:00:00 2001
From: Godbach
Date: Wed, 17 Dec 2014 16:14:26 +0800
Subject: [PATCH 1/2] OPTIM/MINOR: epoll: epoll_ev
Hi Godbach,
On Wed, Dec 17, 2014 at 04:41:33PM +0800, Godbach wrote:
> From 798d50b1922e9680ea69cbc39d54f20665c782da Mon Sep 17 00:00:00 2001
> From: Godbach
> Date: Wed, 17 Dec 2014 16:14:26 +0800
> Subject: [PATCH 1/2] OPTIM/MINOR: epoll: epoll_events should be allocated
> according to global.
Hi Willy,
On 2014/12/17 16:40, Willy Tarreau wrote:
In my opinion it's a cleanup since we're removing a leftover from an
ancient piece of code :-)
Willy
OK, I agree with you and please modify the patch directly.
--
Best Regards,
Godbach
Hi Willy,
On 2014/12/17 16:03, Godbach wrote:
On 2014/12/17 15:15, Willy Tarreau wrote:
In my opinion, absmaxevents should be passed to epoll_wait()
instead of global.tune.maxpollevents.
No, that would defeat the principle of maxpollevents. In fact, I found
what happened : commit f2e8ee2b
On Wed, Dec 17, 2014 at 04:03:19PM +0800, Godbach wrote:
> Got it. I also confused by the comment of absmaxevents before. And now I
> know how to fix this issue.
>
> >
> >Do you want to work on such a patch ?
> >
>
> Yes, I can send the patch later as you suggested:
> 1. remove the definition of
On 2014/12/17 15:15, Willy Tarreau wrote:
In my opinion, absmaxevents should be passed to epoll_wait()
instead of global.tune.maxpollevents.
No, that would defeat the principle of maxpollevents. In fact, I found
what happened : commit f2e8ee2b introduced an optimization in the old
speculativ
Hi Godbach,
On Wed, Dec 17, 2014 at 02:52:55PM +0800, Godbach wrote:
> Hi Willy,
>
> I have noticed that epoll_wait() is called with the following parameters
> boht in latest snapshot and 1.5:
>
> src/ev_epoll.c
> REGPRM2 static void _do_poll(struct poller *p, int exp)
> {
> ...
> status = epol
Hi Willy,
I have noticed that epoll_wait() is called with the following parameters
boht in latest snapshot and 1.5:
src/ev_epoll.c
REGPRM2 static void _do_poll(struct poller *p, int exp)
{
...
status = epoll_wait(epoll_fd, epoll_events, global.tune.maxpollevents,
wait_time);
...
}
That's to
8 matches
Mail list logo
