Re: [PATCH] [BUG/MINOR]: TLS Ticket Key rotation broken via socket command

2015-08-20 Thread Pradeep Jindal
OK, I was testing key rotation when I didn't get expected behaviour, thought of looking at the code and found the bug. On Aug 20, 2015 6:37 PM, Nenad Merdanovic ni...@nimzo.info wrote: Hello, On 8/20/2015 2:55 PM, Pradeep Jindal wrote: Hi, It seems haproxy was doing wrong pointer

Re: [PATCH] [BUG/MINOR]: TLS Ticket Key rotation broken via socket command

2015-08-20 Thread Pradeep Jindal
Gotcha, thanks. On Aug 20, 2015 7:55 PM, Willy Tarreau w...@1wt.eu wrote: Hi Praddep, On Thu, Aug 20, 2015 at 06:25:17PM +0530, Pradeep Jindal wrote: Hi, It seems haproxy was doing wrong pointer arithmetic to update the ticket ring correctly. Here's a small patch, self descriptive.

Re: [PATCH] [BUG/MINOR]: TLS Ticket Key rotation broken via socket command

2015-08-20 Thread Willy Tarreau
Hi Praddep, On Thu, Aug 20, 2015 at 06:25:17PM +0530, Pradeep Jindal wrote: Hi, It seems haproxy was doing wrong pointer arithmetic to update the ticket ring correctly. Here's a small patch, self descriptive. This patch is against the github master branch. Patch applied, thanks. BTW,

[PATCH] [BUG/MINOR]: TLS Ticket Key rotation broken via socket command

2015-08-20 Thread Pradeep Jindal
Hi, It seems haproxy was doing wrong pointer arithmetic to update the ticket ring correctly. Here's a small patch, self descriptive. This patch is against the github master branch. Thanks - Pradeep Jindal tls-ticket-keys-rotation.patch Description: Binary data

Re: [PATCH] [BUG/MINOR]: TLS Ticket Key rotation broken via socket command

2015-08-20 Thread Nenad Merdanovic
Hello, On 8/20/2015 2:55 PM, Pradeep Jindal wrote: Hi, It seems haproxy was doing wrong pointer arithmetic to update the ticket ring correctly. Here's a small patch, self descriptive. This patch is against the github master branch. Thanks for spotting this. Looking at it, I am not sure