Re: [PATCH] BUG/MAJOR: dns: create one client UDP socket per process

2017-02-02 Thread Willy Tarreau
On Thu, Feb 02, 2017 at 11:59:36PM +0100, Baptiste wrote: > Here you go. > > Instead of freeing memory and let the function to allocate an other chunk, > I do a memset and do allocate memory only if the dgram pointer is not yet > set. > I wrote 2 patches: one to modify the function dns_init_resolv

Re: [PATCH] BUG/MAJOR: dns: create one client UDP socket per process

2017-02-02 Thread Baptiste
Here you go. Instead of freeing memory and let the function to allocate an other chunk, I do a memset and do allocate memory only if the dgram pointer is not yet set. I wrote 2 patches: one to modify the function dns_init_resolvers and one to enable the closing of the socket after the fork(). Bap

Re: [PATCH] BUG/MAJOR: dns: create one client UDP socket per process

2017-01-31 Thread Willy Tarreau
On Tue, Jan 31, 2017 at 01:09:15PM +0100, Baptiste wrote: > Understood. Let's use this Sunday as a dead line. Perfect, that works for me. > I think I can make dns_init_resolvers() to take an argument 'int > close_socket' whose value could be 0 or 1. > If 1, then HAProxy will try to close the soc

Re: [PATCH] BUG/MAJOR: dns: create one client UDP socket per process

2017-01-31 Thread Baptiste
On Tue, Jan 31, 2017 at 2:14 AM, Willy Tarreau wrote: > Hi Baptiste, > > On Mon, Jan 30, 2017 at 11:07:53PM +0100, Baptiste wrote: > > Hi all, > > > > Please find attached a patch to fix the issue reported by Joshua on the > ML > > and sjiveson on discourse. > > I moved the initialisation of the

Re: [PATCH] BUG/MAJOR: dns: create one client UDP socket per process

2017-01-30 Thread Willy Tarreau
Hi Baptiste, On Mon, Jan 30, 2017 at 11:07:53PM +0100, Baptiste wrote: > Hi all, > > Please find attached a patch to fix the issue reported by Joshua on the ML > and sjiveson on discourse. > I moved the initialisation of the dns_resolvers() after the fork. I can > confirm now than each process ha

[PATCH] BUG/MAJOR: dns: create one client UDP socket per process

2017-01-30 Thread Baptiste
9c77b0f8e1ecee1a330827e134d0f346582f54f9 Mon Sep 17 00:00:00 2001 From: Baptiste Assmann Date: Mon, 30 Jan 2017 22:22:45 +0100 Subject: [PATCH] BUG/MAJOR: dns: create one client UDP socket per process DNS resolution at run time was incompatible with multi-process mode because FDs for UDP client socket were initialized