Re: [PATCH] BUG/MEDIUM: email-alert: don't set server check status from a email-alert task

2017-12-07 Thread Willy Tarreau
Hi Pieter, On Thu, Dec 07, 2017 at 11:02:13PM +0100, PiBa-NL wrote: > Made a new version of it with a bit of extra comments inside the code, > removed a unrelated white-space change, and added a matching patch > description. OK, now applied, thank you! Willy

Re: [PATCH] BUG/MEDIUM: email-alert: don't set server check status from a email-alert task

2017-12-07 Thread PiBa-NL
create it under his own name? Either way is fine for me. :) Regards, PiBa-NL / Pieter From 3129e1ae21e41a026f6d067b3658f6643835974c Mon Sep 17 00:00:00 2001 From: PiBa-NL <pba_...@yahoo.com> Date: Wed, 6 Dec 2017 01:35:43 +0100 Subject: [PATCH] BUG/MEDIUM: email-alert: don't set server

Re: [PATCH] BUG/MEDIUM: email-alert: don't set server check status from a email-alert task

2017-12-07 Thread Willy Tarreau
On Thu, Dec 07, 2017 at 04:27:16PM +0100, Christopher Faulet wrote: > Honestly, I don't know which version is the best. Just let me know guys :-) > Email alerts should > probably be rewritten to not use the checks. This was the only solution to > do connections by hand when Simon implemented it.

Re: [PATCH] BUG/MEDIUM: email-alert: don't set server check status from a email-alert task

2017-12-07 Thread Emeric Brun
ieter > >> From bf80b0398c08f94bebec30feaaddda422cb87ba1 Mon Sep 17 00:00:00 2001 >> From: PiBa-NL <pba_...@yahoo.com> >> Date: Wed, 6 Dec 2017 01:35:43 +0100 >> Subject: [PATCH] BUG/MEDIUM: email-alert: don't set server check status from >> a >> email-ale

Re: [PATCH] BUG/MEDIUM: email-alert: don't set server check status from a email-alert task

2017-12-05 Thread Willy Tarreau
or should be done differently. > > Thanks in advance, > PiBa-NL / Pieter > From bf80b0398c08f94bebec30feaaddda422cb87ba1 Mon Sep 17 00:00:00 2001 > From: PiBa-NL <pba_...@yahoo.com> > Date: Wed, 6 Dec 2017 01:35:43 +0100 > Subject: [PATCH] BUG/MEDIUM: email-alert:

[PATCH] BUG/MEDIUM: email-alert: don't set server check status from a email-alert task

2017-12-05 Thread PiBa-NL
-alert: don't set server check status from a email-alert task This avoids possible 100% cpu usage deadlock on a EMAIL_ALERTS_LOCK and avoids sending lots of emails when 'option log-health-checks' is used. It is avoided to change the server state and possibly queue a new email while processing the