Re: [PATCH] BUG/MINOR: option prefer-last-server must be ignored in some case

HI Willy, 2017-01-01 10:08 GMT+01:00 Willy Tarreau : > Hi Olivier, > > You see that's always the same with contributors who say they don't > code in C, their first patches are always very clean :-) > > I have some comments below on the implementation itself however, as I > think it

[PATCH] BUG/MINOR: option prefer-last-server must be ignored in some case

From: Olivier Doucet when using "option prefer-last-server", we may not always stay on the same backend if option balance told us otherwise. For example, backend may change in the following cases: balance hdr() balance rdp-cookie balance source balance uri balance url_param

Re: [PATCH] BUG/MINOR: option prefer-last-server must be ignored in some case

Hi Olivier, You see that's always the same with contributors who say they don't code in C, their first patches are always very clean :-) I have some comments below on the implementation itself however, as I think it doesn't completely address the issue : On Wed, Dec 28, 2016 at 06:14:12PM

Re: [PATCH] BUG/MINOR: option prefer-last-server must be ignored in some case

Hi all, This is my very first contribution in C in an important project. Please, be kind :) - format check with Torvald's checkpatch.pl : OK - compile test : OK - small working test : OK (working as expected on a very small test) Feel free to comment so I can improve next time. Olivier

[PATCH] BUG/MINOR: option prefer-last-server must be ignored in some case

when using "option prefer-last-server", we may not always stay on the same backend if we have one of the following option: balance uri balance url_param balance hdr() balance rdp-cookie --- src/backend.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/backend.c