Re: [PATCH] BUG/MINOR: sample: Rename SenderComID/TargetComID to SenderCompID/TargetCompID

2021-03-10 Thread William Lallemand 
On Wed, Mar 10, 2021 at 08:24:24AM +0100, Baptiste wrote:
> On Wed, Mar 10, 2021 at 5:15 AM Daniel Corbett  wrote:
> 
> > Hello,
> >
> >
> >
> >
> >
> > The recently introduced Financial Information eXchange (FIX)
> >
> > converters have some hard coded tags based on the specification that
> >
> > were misspelled. Specifically, SenderComID and TargetComID should
> >
> > be SenderCompID and TargetCompID according to the specification [1][2].
> >
> >
> >
> > This patch updates all references, which includes the converters
> >
> > themselves, the regression test, and the documentation.
> >
> >
> >
> > [1] https://fiximate.fixtrading.org/en/FIX.5.0SP2_EP264/tag49.html
> >
> > [2] https://fiximate.fixtrading.org/en/FIX.5.0SP2_EP264/tag56.html
> >
> >
> >
> >
> >
> >
> >
> > Thanks,
> >
> > -- Daniel
> >
> >
> >
> 
> Hi,
> 
> Thank you Daniel for reporting / fixing this.
> The patch looks correct and may be applied.
> 
> Baptiste

Thanks, applied.

-- 
William Lallemand

Re: [PATCH] BUG/MINOR: sample: Rename SenderComID/TargetComID to SenderCompID/TargetCompID

2021-03-09 Thread Baptiste 
On Wed, Mar 10, 2021 at 5:15 AM Daniel Corbett  wrote:

> Hello,
>
>
>
>
>
> The recently introduced Financial Information eXchange (FIX)
>
> converters have some hard coded tags based on the specification that
>
> were misspelled. Specifically, SenderComID and TargetComID should
>
> be SenderCompID and TargetCompID according to the specification [1][2].
>
>
>
> This patch updates all references, which includes the converters
>
> themselves, the regression test, and the documentation.
>
>
>
> [1] https://fiximate.fixtrading.org/en/FIX.5.0SP2_EP264/tag49.html
>
> [2] https://fiximate.fixtrading.org/en/FIX.5.0SP2_EP264/tag56.html
>
>
>
>
>
>
>
> Thanks,
>
> -- Daniel
>
>
>

Hi,

Thank you Daniel for reporting / fixing this.
The patch looks correct and may be applied.

Baptiste

[PATCH] BUG/MINOR: sample: Rename SenderComID/TargetComID to SenderCompID/TargetCompID

2021-03-09 Thread Daniel Corbett 
Hello,

 

 

The recently introduced Financial Information eXchange (FIX)

converters have some hard coded tags based on the specification that

were misspelled. Specifically, SenderComID and TargetComID should

be SenderCompID and TargetCompID according to the specification [1][2].

 

This patch updates all references, which includes the converters

themselves, the regression test, and the documentation.

 

[1] https://fiximate.fixtrading.org/en/FIX.5.0SP2_EP264/tag49.html

[2] https://fiximate.fixtrading.org/en/FIX.5.0SP2_EP264/tag56.html

 

 

 

Thanks,

-- Daniel

 



0001-BUG-MINOR-sample-Rename-SenderComID-TargetComID-to-S.patch
Description: Binary data