Re: [PATCH] BUG/MINOR: ssl: Stop passing dynamic strings as format arguments

2020-02-19 Thread William Lallemand
On Wed, Feb 19, 2020 at 11:41:13AM +0100, Tim Duesterhus wrote: > gcc complains rightfully: > > src/ssl_sock.c: In function ‘ssl_load_global_issuers_from_path’: > src/ssl_sock.c:9860:4: warning: format not a string literal and no format > arguments [-Wformat-security] > ha_warning(warn); >

Re: [PATCH] BUG/MINOR: ssl: Stop passing dynamic strings as format arguments

2020-02-19 Thread Илья Шипицин
It happens because we now run ERR=1 in ci builds On Wed, Feb 19, 2020, 3:41 PM Tim Duesterhus wrote: > gcc complains rightfully: > > src/ssl_sock.c: In function ‘ssl_load_global_issuers_from_path’: > src/ssl_sock.c:9860:4: warning: format not a string literal and no format > arguments

[PATCH] BUG/MINOR: ssl: Stop passing dynamic strings as format arguments

2020-02-19 Thread Tim Duesterhus
gcc complains rightfully: src/ssl_sock.c: In function ‘ssl_load_global_issuers_from_path’: src/ssl_sock.c:9860:4: warning: format not a string literal and no format arguments [-Wformat-security] ha_warning(warn); ^ Introduced in 70df7bf19cebd5593c0abb01923e6c9f72961da6. ---

Re: [PATCH] BUG/MINOR: ssl: Stop passing dynamic strings as format arguments

2019-11-25 Thread Tim Düsterhus
William, Am 25.11.19 um 08:57 schrieb William Lallemand: > Merged, Thanks Tim. > > I removed the mention to the backport because it's in master only and mustn't > be backported. > When the other commit is not going to be backported either then that's okay :-) Thanks Tim Düsterhus

Re: [PATCH] BUG/MINOR: ssl: Stop passing dynamic strings as format arguments

2019-11-24 Thread William Lallemand
On Sat, Nov 23, 2019 at 11:52:30PM +0100, Tim Duesterhus wrote: > gcc complains rightfully: > > src/ssl_sock.c: In function ‘ssl_sock_prepare_all_ctx’: > src/ssl_sock.c:5507:3: warning: format not a string literal and no format > arguments [-Wformat-security] >ha_warning(errmsg); >^ >

[PATCH] BUG/MINOR: ssl: Stop passing dynamic strings as format arguments

2019-11-23 Thread Tim Duesterhus
gcc complains rightfully: src/ssl_sock.c: In function ‘ssl_sock_prepare_all_ctx’: src/ssl_sock.c:5507:3: warning: format not a string literal and no format arguments [-Wformat-security] ha_warning(errmsg); ^ src/ssl_sock.c:5509:3: warning: format not a string literal and no format