Re: [PATCH] BUG/MINOR: ssl: return alpn string with NULL terminated

2018-02-27 Thread Willy Tarreau
On Tue, Feb 27, 2018 at 04:48:18PM +0100, Emmanuel Hocdet wrote: > > Where exactly did you face the problem ? I'm pretty sure that it's this > > specific place which needs to be fixed. > > > Is for make_tlv with PP2_TYPE_ALPN. I will look at this place. OK, thanks for the pointer. But from what

Re: [PATCH] BUG/MINOR: ssl: return alpn string with NULL terminated

2018-02-27 Thread Emmanuel Hocdet
Hi Willy > Le 27 févr. 2018 à 15:57, Willy Tarreau a écrit : > > Hi Manu, > > On Mon, Feb 26, 2018 at 12:31:13PM +0100, Emmanuel Hocdet wrote: >> >> Hi, >> >> According to openssl documentation: "SSL_get0_alpn_selected() returns >> a pointer to the selected protocol in data with

Re: [PATCH] BUG/MINOR: ssl: return alpn string with NULL terminated

2018-02-27 Thread Willy Tarreau
Hi Manu, On Mon, Feb 26, 2018 at 12:31:13PM +0100, Emmanuel Hocdet wrote: > > Hi, > > According to openssl documentation: "SSL_get0_alpn_selected() returns > a pointer to the selected protocol in data with length len. It is not > NUL-terminated". It consern ssl_sock_get_alpn and

[PATCH] BUG/MINOR: ssl: return alpn string with NULL terminated

2018-02-26 Thread Emmanuel Hocdet
Hi, According to openssl documentation: "SSL_get0_alpn_selected() returns a pointer to the selected protocol in data with length len. It is not NUL-terminated". It consern ssl_sock_get_alpn and smp_fetch_ssl_fc_alpn functions and impact send-proxy-v2 with alpn. The expected get is not an array