Re: [PATCH] BUG: NetScaler CIP handling is incorrect

On 21/12/17 13:28, Willy Tarreau wrote: > On Thu, Dec 21, 2017 at 10:46:17AM +, Bertrand Jacquin wrote: >> I'm all good with backporting this in 1.8. Feel free to. > > Great, now merged. Do not hesitate to report back any issues you > would notice on your infrastructure. Thanks Willy, sure

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

On Thu, Dec 21, 2017 at 10:46:17AM +, Bertrand Jacquin wrote: > I'm all good with backporting this in 1.8. Feel free to. Great, now merged. Do not hesitate to report back any issues you would notice on your infrastructure. cheers, Willy

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

Hi Willy, On 21/12/17 10:08, Willy Tarreau wrote: > On Thu, Dec 21, 2017 at 11:05:30AM +0100, Andreas Mahnke wrote: >> Hi Willy, >> >> The support of the standard protocol in 1.8 would be nice, because we are >> planning to migrate to haproxy 1.8 from our self - patched 1.7 instances. > > OK.

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

On Thu, Dec 21, 2017 at 11:05:30AM +0100, Andreas Mahnke wrote: > Hi Willy, > > The support of the standard protocol in 1.8 would be nice, because we are > planning to migrate to haproxy 1.8 from our self - patched 1.7 instances. OK. Bertrand, if you don't scream quickly, I'll pick your patches

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

Hi Willy, The support of the standard protocol in 1.8 would be nice, because we are planning to migrate to haproxy 1.8 from our self - patched 1.7 instances. Regards, Andreas On Thu, Dec 21, 2017 at 10:57 AM, Willy Tarreau wrote: > Bertrand, Andreas, > > The NS CIP fixes were

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

Bertrand, Andreas, The NS CIP fixes were backported to 1.8. Initially I was not considering backporting your latest changes to support the new version of the protocol since it's a feature addition. But now that I'm thinking about it, the change is minimal and very well isolated and you very

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

Great, thank you guys! Best regards, Andreas On Wed, Dec 20, 2017 at 7:06 AM, Willy Tarreau wrote: > On Tue, Dec 19, 2017 at 11:10:58PM +, Bertrand Jacquin wrote: > > Hi Andreas and Willy, > > > > Please find attached a patch serie adding support for both legacy and > >

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

On Tue, Dec 19, 2017 at 11:10:58PM +, Bertrand Jacquin wrote: > Hi Andreas and Willy, > > Please find attached a patch serie adding support for both legacy and > standard CIP protocol while keeping compatibility with current > configuration format. Excellent, now applied to 1.9, will

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

Hi Andreas and Willy, Please find attached a patch serie adding support for both legacy and standard CIP protocol while keeping compatibility with current configuration format. This also fixes numerous bugs spotted during this dev cycle and present since the first version of the patch. This

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

Hi Andreas, I got this really side tracked, my apology. Let me take a look at that this evening again. Some corps need to be unburied. I'm afraid the patch, as is, will break compatibility with other version of the CIP protocol, I'd like haproxy to support both of them. Cheers, Bertrand On

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

Hi Andreas, On Thu, Dec 07, 2017 at 02:41:29PM +0100, Andreas Mahnke wrote: > Hello everybody, > > Is there an update regarding the merging of the patch? We are thinking to > switch to version 1.8 in the near future and it would be nice to have the > patch merged, so that we do not need to merge

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

On Fri, Jul 07, 2017 at 02:36:07PM +0200, Andreas Mahnke wrote: > Hi Willy, > > I had some direct mail conversations with him and he wanted to create a > patch based in the findings. > In the meantime we got it working using the patch I provided, therefore I > sent it yesterday so that it gets

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

. Maybe Bertrand is/was using > a different version ? > > Thanks, > Willy > > > > From 2482fc346033cbc8a74cd36d9ef27db4bb0daf6c Mon Sep 17 00:00:00 2001 > > From: mahnke <andreas.mah...@hansemerkur.de> > > Date: Thu, 6 Jul 2017 12:56:10 +0200 > >

Re: [PATCH] BUG: NetScaler CIP handling is incorrect

different version ? Thanks, Willy > From 2482fc346033cbc8a74cd36d9ef27db4bb0daf6c Mon Sep 17 00:00:00 2001 > From: mahnke <andreas.mah...@hansemerkur.de> > Date: Thu, 6 Jul 2017 12:56:10 +0200 > Subject: [PATCH] BUG: NetScaler CIP handling is incorrect > > The "Net

[PATCH] BUG: NetScaler CIP handling is incorrect

eas >From 2482fc346033cbc8a74cd36d9ef27db4bb0daf6c Mon Sep 17 00:00:00 2001 From: mahnke <andreas.mah...@hansemerkur.de> Date: Thu, 6 Jul 2017 12:56:10 +0200 Subject: [PATCH] BUG: NetScaler CIP handling is incorrect The "NetScaler CIP handling" implementation was not working as expected. Based on tcp