Re: [PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

2021-06-17 Thread Willy Tarreau
On Thu, Jun 17, 2021 at 12:31:45PM +0200, Tim Düsterhus wrote: > Willy, > > On 6/13/21 3:02 PM, Tim Duesterhus wrote: > > Using 'sudo' required quite a few workarounds in various places. Setting an > > explicit 'ulimit -n' removes the requirement for 'sudo', resulting in a > > cleaner > >

Re: [PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

2021-06-17 Thread Willy Tarreau
Hi Tim, On Thu, Jun 17, 2021 at 12:31:45PM +0200, Tim Düsterhus wrote: > Willy, > > On 6/13/21 3:02 PM, Tim Duesterhus wrote: > > Using 'sudo' required quite a few workarounds in various places. Setting an > > explicit 'ulimit -n' removes the requirement for 'sudo', resulting in a > > cleaner >

Re: [PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

2021-06-17 Thread Tim Düsterhus
Willy, On 6/13/21 3:02 PM, Tim Duesterhus wrote: Using 'sudo' required quite a few workarounds in various places. Setting an explicit 'ulimit -n' removes the requirement for 'sudo', resulting in a cleaner workflow configuration. You might've missed this one. Ilya already acked it and I tested

Re: [PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

2021-06-13 Thread Илья Шипицин
Anyway, ACK from me. ulimit is less evil than sudo On Sun, Jun 13, 2021, 4:25 PM Tim Düsterhus wrote: > Ilya, > > On 6/13/21 3:18 PM, Илья Шипицин wrote: > > It was in my to do list as well. I recall I ran tests without increasing > > limits. > > > > Which test requires 5 open files? Maybe

Re: [PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

2021-06-13 Thread Tim Düsterhus
Ilya, On 6/13/21 3:18 PM, Илья Шипицин wrote: It was in my to do list as well. I recall I ran tests without increasing limits. Which test requires 5 open files? Maybe the one currently disabled? Also, it does not like a good pattern to open so many files. If we really use as many files,

Re: [PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

2021-06-13 Thread Илья Шипицин
It was in my to do list as well. I recall I ran tests without increasing limits. Which test requires 5 open files? Maybe the one currently disabled? Also, it does not like a good pattern to open so many files. If we really use as many files, shouldn't we revisit that area? On Sun, Jun 13,

[PATCH] CI: Replace the requirement for 'sudo' with a call to 'ulimit -n'

2021-06-13 Thread Tim Duesterhus
Using 'sudo' required quite a few workarounds in various places. Setting an explicit 'ulimit -n' removes the requirement for 'sudo', resulting in a cleaner workflow configuration. --- .github/workflows/vtest.yml | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git