Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

2018-12-02 Thread Willy Tarreau
Hi Joseph, On Sun, Nov 25, 2018 at 12:35:21PM -0800, Joseph Herlant wrote: > Will do, thanks! > On Sun, Nov 25, 2018 at 12:10 PM William Lallemand > wrote: > > > > On Sun, Nov 25, 2018 at 11:30:06AM -0800, Joseph Herlant wrote: > > > Sorry, I forgot the attachement on this one. > > > > Hi

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

2018-11-25 Thread Joseph Herlant
Fixes typos in the code comments of the proto_tcp subsystem. --- src/proto_tcp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/proto_tcp.c b/src/proto_tcp.c index c7951c55..6f2683c5 100644 --- a/src/proto_tcp.c +++ b/src/proto_tcp.c @@ -1534,11 +1534,11 @@

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

2018-11-25 Thread Joseph Herlant
On Sun, Nov 25, 2018 at 12:47 PM Valentin Vidic wrote: > Should this sentence read: > > Returns some tcp_info data if it's available. Indeed, good catch, thanks, I will update the patch. Thanks, Joseph

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

2018-11-25 Thread Valentin Vidic
On Sun, Nov 25, 2018 at 11:30:06AM -0800, Joseph Herlant wrote: > -/* Returns some tcp_info data is its avalaible. "dir" must be set to 0 if > - * the client connection is require, otherwise it is set to 1. "val" > represents > +/* Returns some tcp_info data is its available. "dir" must be set to

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

2018-11-25 Thread Joseph Herlant
Will do, thanks! On Sun, Nov 25, 2018 at 12:10 PM William Lallemand wrote: > > On Sun, Nov 25, 2018 at 11:30:06AM -0800, Joseph Herlant wrote: > > Sorry, I forgot the attachement on this one. > > Hi Joseph, > > I recommand you to use git send-email to avoid that, it can send a whole patch >

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

2018-11-25 Thread William Lallemand
On Sun, Nov 25, 2018 at 11:30:06AM -0800, Joseph Herlant wrote: > Sorry, I forgot the attachement on this one. Hi Joseph, I recommand you to use git send-email to avoid that, it can send a whole patch series in a unique mail thread, and it's easier for us to apply a patch which is not an

Re: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

2018-11-25 Thread Joseph Herlant
ep 17 00:00:00 2001 From: Joseph Herlant Date: Sun, 25 Nov 2018 11:07:33 -0800 Subject: [PATCH] CLEANUP: Fix typos in the proto_tcp subsystem Fixes typos in the code comments of the proto_tcp subsystem. --- src/proto_tcp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] CLEANUP: Fix typos in the proto_tcp subsystem

2018-11-25 Thread Joseph Herlant
Hi, The attached patch fixes typos in the code comments of the proto_tcp subsystem. Thanks, Joseph