Re: [PATCH] CONTRIB: log: exit with warning when -sf/-sd cannot parse argument

2018-02-05 Thread Willy Tarreau
On Mon, Feb 05, 2018 at 11:17:24PM +, Christopher Lane wrote: > Yikes! Sorry about that sprintf issue. I could have sworn I was getting > warnings from one of my compilers without the (char *) but not able to > recreate. New patch under heading [PATCH] CONTRIB: log: exit with warni

Re: [PATCH] CONTRIB: log: exit with warning when -sf/-sd cannot parse argument

2018-02-05 Thread Christopher Lane
ut only 2 > given. Also, you don't need to cast them to "char *", it's already OK. > > Yikes! Sorry about that sprintf issue. I could have sworn I was getting warnings from one of my compilers without the (char *) but not able to recreate. New patch under heading [PATCH] CONTRIB: log: exit with warning when -sf/-sd cannot parse argument <2nd> Thanks, Chris > Thanks, > Willy >

Re: [PATCH] CONTRIB: log: exit with warning when -sf/-sd cannot parse argument

2018-02-05 Thread Willy Tarreau
Hi Chris, On Sat, Feb 03, 2018 at 10:08:58PM +, Chris Lane wrote: > diff --git a/src/haproxy.c b/src/haproxy.c > index f1a2fb9..30490b3 100644 > --- a/src/haproxy.c > +++ b/src/haproxy.c > @@ -1445,13 +1445,26 @@ static void init(int argc, char **argv) > else >

[PATCH] CONTRIB: log: exit with warning when -sf/-sd cannot parse argument

2018-02-03 Thread Chris Lane
(from git format-patch -1 as per mail thread [PATCH] CONTRIB: log: emit warning when -sf/-sd cannot parse argument) Previously, -sf and -sd command line parsing used atol which cannot detect errors. I had a problem where I was doing -sf "$pid1 $pid2 $pid" and it was sending the gracefully termi