Re: [PATCH] Fix 'tcp-request content [accept|reject] if condition' parser for missing 'if'.

2009-05-13 Thread Maik Broemme
Hi, Willy Tarreau wrote: > On Wed, May 13, 2009 at 11:50:07AM +0200, Maik Broemme wrote: > > I don't get you. You mean that simply omitting the "if" between "reject" and > "cond" is not returned as an error, that's it ? If so, yes I agree that it > would be better that it yells here. Since I cop

Re: [PATCH] Fix 'tcp-request content [accept|reject] if condition' parser for missing 'if'.

2009-05-13 Thread Willy Tarreau
On Wed, May 13, 2009 at 11:50:07AM +0200, Maik Broemme wrote: > > The second case above was precisely what led me to discover the segfault > > bug, which was introduced in 1.3.17 with the refinement of the config > > warnings. But the behaviour has not changed since 1.3.16. > > > > You have misse

Re: [PATCH] Fix 'tcp-request content [accept|reject] if condition' parser for missing 'if'.

2009-05-13 Thread Maik Broemme
Hi, Willy Tarreau wrote: > Hi Maik, > > On Tue, May 12, 2009 at 01:36:46AM +0200, Maik Broemme wrote: > > Hi, > > > > attached is a patch which fixes a configuration mistake regarding the > > 'tcp-request' option. If you have the following in your configuration > > file: > > > > acl

Re: [PATCH] Fix 'tcp-request content [accept|reject] if condition' parser for missing 'if'.

2009-05-12 Thread Willy Tarreau
Hi Maik, On Tue, May 12, 2009 at 01:36:46AM +0200, Maik Broemme wrote: > Hi, > > attached is a patch which fixes a configuration mistake regarding the > 'tcp-request' option. If you have the following in your configuration > file: > > acl localnet dst 10.0.0.0/8 > tcp-req

[PATCH] Fix 'tcp-request content [accept|reject] if condition' parser for missing 'if'.

2009-05-11 Thread Maik Broemme
Hi, attached is a patch which fixes a configuration mistake regarding the 'tcp-request' option. If you have the following in your configuration file: acl localnet dst 10.0.0.0/8 tcp-request content reject if localnet This will work fine, but if you change the 'tcp