Re: [PATCH] Fix OSX compilation errors
On Sun, Sep 11, 2016 at 08:52:17AM -0400, Dinko Korunic wrote: > Hi Willy, > > I can backport them ??? in 1.5 and 1.4 we???d also have to use IPPROTO_IP > instead of SOL_IP on OSX, as SOL_IP is simply not defined for > setsockopt(). I think that we could use something along these lines: > > #ifndef SOL_IP > # define SOL_IP IPPROTO_IP > #endif Indeed, this can be added by backporting commit ae459f3b (to keep the code easier to track). > Let me know what you think. As you seem to have the hardware needed to validate this, yes I'd rather let you backport those. Thanks, Willy
Re: [PATCH] Fix OSX compilation errors
Hi Willy, I can backport them — in 1.5 and 1.4 we’d also have to use IPPROTO_IP instead of SOL_IP on OSX, as SOL_IP is simply not defined for setsockopt(). I think that we could use something along these lines: #ifndef SOL_IP # define SOL_IP IPPROTO_IP #endif Let me know what you think. Kind regards, D. -- Dinko Korunic ** Standard disclaimer applies ** On 11 September 2016 at 08:06:11, Willy Tarreau (w...@1wt.eu(mailto:w...@1wt.eu)) wrote: > Hi Dinko, > > On Fri, Sep 09, 2016 at 12:52:55AM -0700, Dinko Korunic wrote: > > The following really trivial patch fixes compilation issues on OSX (El > > Capitan at least). > > Applied, thanks. Do you want it backported to 1.6 and maybe even 1.5 ? > The seem to be affected as well. > > Thanks, > Willy
Re: [PATCH] Fix OSX compilation errors
Hi Dinko, On Fri, Sep 09, 2016 at 12:52:55AM -0700, Dinko Korunic wrote: > The following really trivial patch fixes compilation issues on OSX (El > Capitan at least). Applied, thanks. Do you want it backported to 1.6 and maybe even 1.5 ? The seem to be affected as well. Thanks, Willy
[PATCH] Fix OSX compilation errors
Hi, The following really trivial patch fixes compilation issues on OSX (El Capitan at least). Kind regards, D. 0001-BUG-MINOR-fix-osx-compilation-errors.patch Description: Binary data
