Re: [PATCH] MINOR: mworker: do not store child pid anymore in the pidfile

2017-11-06 Thread Pavlos Parissis
On 06/11/2017 03:19 μμ, Willy Tarreau wrote: > Hi Pavlos, > > On Mon, Nov 06, 2017 at 03:09:10PM +0100, Pavlos Parissis wrote: >> That will be very much appreciated as it will allow us to have a smooth >> migration to the new master process model. > > In fact the current behaviour is to continue

Re: [PATCH] MINOR: mworker: do not store child pid anymore in the pidfile

2017-11-06 Thread Pavlos Parissis
On 06/11/2017 01:35 μμ, William Lallemand wrote: > On Mon, Nov 06, 2017 at 12:11:13PM +0100, Pavlos Parissis wrote: >> On 06/11/2017 11:16 πμ, William Lallemand wrote: >>> The parent process supervises itself the children, we don't need to >>> store the children pids anymore in the pidfile in

Re: [PATCH] MINOR: mworker: do not store child pid anymore in the pidfile

2017-11-06 Thread Pavlos Parissis
On 06/11/2017 11:16 πμ, William Lallemand wrote: > The parent process supervises itself the children, we don't need to > store the children pids anymore in the pidfile in master-worker mode. I have a small objection against this. Having PIDs in a file allows external tools to monitor the

[PATCH] MINOR: mworker: do not store child pid anymore in the pidfile

2017-11-06 Thread William Lallemand
The parent process supervises itself the children, we don't need to store the children pids anymore in the pidfile in master-worker mode. --- src/haproxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/haproxy.c b/src/haproxy.c index bcbbad4a1..4d4bd3b26 100644 ---