Re: [PATCH] MINOR: mworker: exit with 0 on successful exit

2018-07-12 Thread Willy Tarreau
On Thu, Jul 12, 2018 at 05:38:34PM +0200, William Lallemand wrote: > On Thu, Jul 12, 2018 at 04:42:01PM +0200, Vincent Bernat wrote: > > ? 12 juillet 2018 16:25 +0200, William Lallemand  : > > > > > Maybe we could take your first patch for the unit file and backport it in > > > 1.8, > > > and

Re: [PATCH] MINOR: mworker: exit with 0 on successful exit

2018-07-12 Thread William Lallemand
On Thu, Jul 12, 2018 at 04:42:01PM +0200, Vincent Bernat wrote: > ❦ 12 juillet 2018 16:25 +0200, William Lallemand  : > > > Maybe we could take your first patch for the unit file and backport it in > > 1.8, > > and then make the appropriate changes for 1.9 once the master was > > redesigned. >

Re: [PATCH] MINOR: mworker: exit with 0 on successful exit

2018-07-12 Thread Vincent Bernat
❦ 12 juillet 2018 16:25 +0200, William Lallemand  : > Maybe we could take your first patch for the unit file and backport it in 1.8, > and then make the appropriate changes for 1.9 once the master was > redesigned. Yes, no problem. The first patch should apply without any change on 1.8. I am

Re: [PATCH] MINOR: mworker: exit with 0 on successful exit

2018-07-12 Thread William Lallemand
On Thu, Jul 12, 2018 at 04:14:34PM +0200, Vincent Bernat wrote: > ❦ 22 juin 2018 22:03 +0200, Vincent Bernat  : > > > Without this patch, when killing the master process, the SIGTERM > > signal is forwarded to all children. Last children will likely exit > > with "killed by signal SIGTERM"

Re: [PATCH] MINOR: mworker: exit with 0 on successful exit

2018-07-12 Thread Vincent Bernat
❦ 22 juin 2018 22:03 +0200, Vincent Bernat  : > Without this patch, when killing the master process, the SIGTERM > signal is forwarded to all children. Last children will likely exit > with "killed by signal SIGTERM" status which would be converted by an > exit with status 143 of the master

Re: [PATCH] MINOR: mworker: exit with 0 on successful exit

2018-06-22 Thread Vincent Bernat
❦ 22 juin 2018 22:03 +0200, Vincent Bernat  : > if (current_child(exitpid)) { > ha_alert("Current worker %d exited with code > %d\n", exitpid, status); This is a lie, but I don't think it matters much. We could (mentally) translate "with code

[PATCH] MINOR: mworker: exit with 0 on successful exit

2018-06-22 Thread Vincent Bernat
Without this patch, when killing the master process, the SIGTERM signal is forwarded to all children. Last children will likely exit with "killed by signal SIGTERM" status which would be converted by an exit with status 143 of the master process. With this patch, the master process takes note it