Hi Nikola,
On Sun, Apr 03, 2022 at 10:34:11PM +0200, Nikola Sale wrote:
> Hi,
>
> Thanks Tim. Here is the updated patch with the version fix in add_item.vtc
> ready for Willy to review.
Reviewed and now merged since I had nothing to add :-)
Thank you!
Willy
Nikola,
On 4/3/22 18:31, Nikola Šale wrote:
Here is the updated patch, I hope it now covers all things you have
mentioned.
In add_item.vtc:
- You need to check for version 2.6-dev0, not 2.5-dev0, as the current
dev release is 2.6.
I don't have any further remarks regarding the patch, but
Hello,
Here is the updated patch, I hope it now covers all things you have
mentioned.
Since one of the purposes of this feature was to mitigate wasting of
processing time by using 2 concat lines I decided to add the checks and
forbid the user to use rules which don't make sense like:
Nikola,
On 4/1/22 16:08, Nikola Šale wrote:
- The square brackets in the converter "signature" in configuration.txt are
mismatched.
- In the explanation there should not be square brackets around [].
Actually, there are no square brackets around :
+add_item(,[][,]])
See Willy's
Hi Nikola,
On Fri, Apr 01, 2022 at 04:08:20PM +0200, Nikola Sale wrote:
> Hi,
>
> Thank you Tim and Willy for your quick and detailed feedback. I'll continue
> working on the patch at the earliest convenience.
OK!
> In the meantime, I'd like to further discuss some points:
>
> - The square
Hi,
Thank you Tim and Willy for your quick and detailed feedback. I'll continue
working on the patch at the earliest convenience.
In the meantime, I'd like to further discuss some points:
- The square brackets in the converter "signature" in configuration.txt are
> mismatched.
> - In the
Nikola,
thanks for your contribution. I agree with Tim's points, and that's a
good indicator of the quality of your patch, since all of this is purely
cosmetic :-)
I do have one minor cosmetic comment to add here:
+static int sample_conv_add_item(const struct arg *arg_p, struct sample *smp,
Nikola,
[dropping one of the Willys from Cc]
On 4/1/22 00:01, Nikola Šale wrote:
That logic was implemented in this patch.
I believe your reading of the issue is correct and the logic makes sense.
Regarding the commit message:
- Please mention the issue like this: "This resolves GitHub
df559401e4495fd0200dd627e5b4344660907196 Mon Sep 17 00:00:00 2001
From: Nikola Sale
Date: Thu, 31 Mar 2022 23:14:41 +0200
Subject: [PATCH] MINOR: sample: converter: Add add_item converter
This new converter is similar to the concat converter and can be used to
build new variables made of a succession of other
9 matches
Mail list logo
