Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-21 Thread Willy Tarreau
On Tue, Jan 22, 2019 at 12:36:41AM +0100, PiBa-NL wrote: > The regtest works for me as well with this patch. Without needing the > 'timeout mail' setting. > > I think we can call it fixed once committed. OK so I've now merged it in dev and 1.9. Thanks! Willy

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-21 Thread PiBa-NL
Hi Christopher, Op 21-1-2019 om 15:28 schreef Christopher Faulet: Hi Pieter, About the timing issue, could you try the following patch please ? With it, I can run the regtest about email alerts without any error. Thanks, -- Christopher Faulet The regtest works for me as well with this

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-21 Thread Christopher Faulet
Le 23/12/2018 à 21:17, PiBa-NL a écrit : Hi List, Attached a new test to verify that the 'mailers' section is working properly. Currently with 1.9 the mailers sends thousands of mails for my setup... As the test is rather slow i have marked it with a starting letter 's'. Note that the test

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-11 Thread Frederic Lecaille
On 1/11/19 12:35 AM, Cyril Bonté wrote: Hi all, Le 08/01/2019 à 10:06, Willy Tarreau a écrit : On Tue, Jan 08, 2019 at 09:31:22AM +0100, Frederic Lecaille wrote: Indeed this script could worked with a short mailer timeout before af4021e6 commit. Another git bisect shows that 53216e7d

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-10 Thread Willy Tarreau
Hi Cyril, On Fri, Jan 11, 2019 at 12:35:12AM +0100, Cyril Bonté wrote: > Well, from what I've seen with a small test, I've a different conclusion > about the commit which introduced the issue. It looks to have been > introduced earlier with commit 0108bb3e4 "MEDIUM: mailers: Init alerts > during

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-10 Thread Cyril Bonté
Hi all, Le 08/01/2019 à 10:06, Willy Tarreau a écrit : On Tue, Jan 08, 2019 at 09:31:22AM +0100, Frederic Lecaille wrote: Indeed this script could worked with a short mailer timeout before af4021e6 commit. Another git bisect shows that 53216e7d introduced the email bombing issue. Note that

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-08 Thread Willy Tarreau
On Tue, Jan 08, 2019 at 09:31:22AM +0100, Frederic Lecaille wrote: > Indeed this script could worked with a short mailer timeout before af4021e6 > commit. Another git bisect shows that 53216e7d introduced the email bombing > issue. > > Note that 33a09a5f refers to 53216e7d commit. > > I am not

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-08 Thread Frederic Lecaille
On 1/7/19 9:24 PM, PiBa-NL wrote: Hi Willy, Op 7-1-2019 om 15:25 schreef Willy Tarreau: Hi Pieter, On Sun, Jan 06, 2019 at 04:38:21PM +0100, PiBa-NL wrote: The 23654 mails received for a failed server is a bit much.. I agree. I really don't know much how the mails work to be honest, as I

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-07 Thread Willy Tarreau
Hi Pieter, On Mon, Jan 07, 2019 at 09:24:24PM +0100, PiBa-NL wrote: > For 1 part its always been broken (needing the short mailer timeout to send > all expected mails), for the other part, at least until 1.8.14 it used to > NOT send thousands of mails so that would be a regression in the current

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-07 Thread PiBa-NL
Hi Willy, Op 7-1-2019 om 15:25 schreef Willy Tarreau: Hi Pieter, On Sun, Jan 06, 2019 at 04:38:21PM +0100, PiBa-NL wrote: The 23654 mails received for a failed server is a bit much.. I agree. I really don't know much how the mails work to be honest, as I have never used them. I remember that

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-07 Thread Willy Tarreau
Hi Pieter, On Sun, Jan 06, 2019 at 04:38:21PM +0100, PiBa-NL wrote: > Hi, > 2 weeks passed without reply, so a little hereby a little 'bump'.. I know > everyone has been busy, but would be nice to get test added or at least the > biggest issue of the 'mailbomb' fixed before next release. If its >

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2019-01-06 Thread PiBa-NL
Hi, 2 weeks passed without reply, so a little hereby a little 'bump'.. I know everyone has been busy, but would be nice to get test added or at least the biggest issue of the 'mailbomb' fixed before next release. If its 'scheduled' to get looked at later thats okay. Just making sure it aint

Re: [PATCH] REG-TEST: mailers: add new test for 'mailers' section

2018-12-23 Thread PiBa-NL
Changed subject of patch requirement to 'REGTEST'. Op 23-12-2018 om 21:17 schreef PiBa-NL: Hi List, Attached a new test to verify that the 'mailers' section is working properly. Currently with 1.9 the mailers sends thousands of mails for my setup... As the test is rather slow i have marked

[PATCH] REG-TEST: mailers: add new test for 'mailers' section

2018-12-23 Thread PiBa-NL
(Pieter) From 49a605bfadaafe25de0f084c7d1d449eef9c23aa Mon Sep 17 00:00:00 2001 From: PiBa-NL Date: Sun, 23 Dec 2018 21:06:31 +0100 Subject: [PATCH] REG-TEST: mailers: add new test for 'mailers' section This test verifies the mailers section works properly by checking that it sends the proper