Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-12 Thread Willy Tarreau
On Fri, Oct 12, 2018 at 02:29:51PM +0200, PiBa-NL wrote: > Op 12-10-2018 om 10:53 schreef William Lallemand: > > The attached patch should fix the issue. > > The patch works for me, thanks. Great, patch now merged. Thanks! Willy

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-12 Thread PiBa-NL
Hi William, Op 12-10-2018 om 10:53 schreef William Lallemand: The attached patch should fix the issue. The patch works for me, thanks. Regards, PiBa-NL (Pieter)

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-12 Thread William Lallemand
On Thu, Oct 11, 2018 at 11:06:38PM +0200, William Lallemand wrote: > On Thu, Oct 11, 2018 at 09:31:48PM +0200, PiBa-NL wrote: > > Hi Willy, William, > > > > Hi Peter, > > Regarding this part: > > > -Connection and request counters to low when ran as regtest from > > varnishtest (bug?) > > It

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-11 Thread William Lallemand
On Thu, Oct 11, 2018 at 09:31:48PM +0200, PiBa-NL wrote: > Hi Willy, William, > Hi Peter, Regarding this part: > -Connection and request counters to low when ran as regtest from > varnishtest (bug?) > It turns out that starting haproxy from varnishtest, and using -W > master-worker mode,

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-11 Thread PiBa-NL
Hi Willy, William, Op 2-10-2018 om 3:56 schreef Willy Tarreau: it's important to cut this into pieces to figure what it's showing. A little update on this issue split in 2 pieces. -Connection and request counters to low when ran as regtest from varnishtest (bug?) It turns out that starting

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-04 Thread Willy Tarreau
Hi Pieter, On Thu, Oct 04, 2018 at 09:43:36PM +0200, PiBa-NL wrote: > Hi Willy, > > Op 2-10-2018 om 3:56 schreef Willy Tarreau: > > it's important to cut this into pieces > > to figure what it's showing. > > Okay, the good thing i suppose we already have a reproduction sort-off.. > > What

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-04 Thread PiBa-NL
Hi Willy, Op 2-10-2018 om 3:56 schreef Willy Tarreau: it's important to cut this into pieces to figure what it's showing. Okay, the good thing i suppose we already have a reproduction sort-off.. What would be the best way to try and get to the bottom of this? Add debug output to haproxy

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-01 Thread Willy Tarreau
Hi Pieter, On Mon, Oct 01, 2018 at 11:06:33PM +0200, PiBa-NL wrote: > I have used the exact config above, and well it 'works fine' ?? Results > below.. both types of nc requests send to 1 running haproxy result in a > proper '21'.. OK. > But even in this case the results would be 'predicable',

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-01 Thread PiBa-NL
Hi Frederic, Op 1-10-2018 om 15:15 schreef Frederic Lecaille: On 09/15/2018 02:03 AM, PiBa-NL wrote: Hi List, Willy, Hi Pieter, Sorry for this late reply. I am also sorry to tell you that -D option should not be used anymore because it as been recently broken. It adds an extra 2s delay on

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-01 Thread PiBa-NL
Hi Willy, Op 1-10-2018 om 4:00 schreef Willy Tarreau: On Sun, Sep 30, 2018 at 10:16:55PM +0200, PiBa-NL wrote: Hi Willy, Op 30-9-2018 om 20:38 schreef Willy Tarreau: On Sun, Sep 30, 2018 at 08:22:23PM +0200, Willy Tarreau wrote: On Sun, Sep 30, 2018 at 07:59:34PM +0200, PiBa-NL wrote:

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-10-01 Thread Frederic Lecaille
On 09/15/2018 02:03 AM, PiBa-NL wrote: Hi List, Willy, Hi Pieter, Sorry for this late reply. I am also sorry to tell you that -D option should not be used anymore because it as been recently broken. It adds an extra 2s delay on my PC. Without this option, on my PC the test fails but after

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-30 Thread PiBa-NL
Hi Willy, Op 30-9-2018 om 20:38 schreef Willy Tarreau: On Sun, Sep 30, 2018 at 08:22:23PM +0200, Willy Tarreau wrote: On Sun, Sep 30, 2018 at 07:59:34PM +0200, PiBa-NL wrote: Indeed it works with 1.8, so in that regard i 'think' the test itself is correct.. Also when disabling threads, or

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-30 Thread Willy Tarreau
On Sun, Sep 30, 2018 at 08:22:23PM +0200, Willy Tarreau wrote: > On Sun, Sep 30, 2018 at 07:59:34PM +0200, PiBa-NL wrote: > > Indeed it works with 1.8, so in that regard i 'think' the test itself is > > correct.. Also when disabling threads, or running only 1 client, it still > > works.. Then both

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-30 Thread Willy Tarreau
On Sun, Sep 30, 2018 at 07:59:34PM +0200, PiBa-NL wrote: > Indeed it works with 1.8, so in that regard i 'think' the test itself is > correct.. Also when disabling threads, or running only 1 client, it still > works.. Then both CumConns CumReq show 11 for the first stats result. Hmmm for me it

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-30 Thread Willy Tarreau
On Sun, Sep 30, 2018 at 07:15:59PM +0200, PiBa-NL wrote: > > on a simple config, the CummConns always matches the CumReq, and when > > running this test I'm seeing random values there in the output, but I > > also see that they are retrieved before all connections are closed > But CurrConns is 0,

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-30 Thread PiBa-NL
Hi Willy, Op 30-9-2018 om 7:46 schreef Willy Tarreau: Hi Pieter, On Sun, Sep 30, 2018 at 12:05:14AM +0200, PiBa-NL wrote: Hi Willy, I thought lets give those reg-test another try :) as its easy to run and dev3 just came out. All tests pass on my FreeBSD system, except this one, new reg-test

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-30 Thread PiBa-NL
Hi Willy, Op 30-9-2018 om 7:56 schreef Willy Tarreau: On Sun, Sep 30, 2018 at 07:46:24AM +0200, Willy Tarreau wrote: Well, at least it works fine on 1.8 and not on 1.9-dev3 so I think you spotted a regression that we have to analyse. However, I'd like to merge the fix before merging the

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-29 Thread Willy Tarreau
On Sun, Sep 30, 2018 at 07:46:24AM +0200, Willy Tarreau wrote: > Well, at least it works fine on 1.8 and not on 1.9-dev3 so I think you > spotted a regression that we have to analyse. However, I'd like to merge > the fix before merging the regtest otherwise it will kill the reg-test > feature

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-29 Thread Willy Tarreau
Hi Pieter, On Sun, Sep 30, 2018 at 12:05:14AM +0200, PiBa-NL wrote: > Hi Willy, > > I thought lets give those reg-test another try :) as its easy to run and > dev3 just came out. > All tests pass on my FreeBSD system, except this one, new reg-test attached. > > Pretty much the same test as

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-29 Thread PiBa-NL
in between. As for all the rest of the email, thanks for your elaborate response :). Regards, PiBa-NL (Pieter) From 28377ffe246ed1db0e0d898fa6263eccdc68c490 Mon Sep 17 00:00:00 2001 From: PiBa-NL Date: Sat, 15 Sep 2018 01:51:54 +0200 Subject: [PATCH] REGTEST/MINOR: loadtest: add a test for

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-20 Thread PiBa-NL
Hi Willy, Op 20-9-2018 om 13:56 schreef Willy Tarreau: For me the test produces like 345 lines of output as attached. which seems not to bad (if the test succeeds). It's already far too much for a user. Well those 345 lines are if it succeeds while in 'verbose' mode, in 'normal' mode it

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-20 Thread Willy Tarreau
Hi Pieter, On Thu, Sep 20, 2018 at 12:48:35AM +0200, PiBa-NL wrote: > Test takes like 5 seconds to run here, and while that is a bit long if you > get a hundred more similar tests and want to continue tweaking developments > while running tests in between. It wouldn't hurt to run such a (series)

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-19 Thread PiBa-NL
Hi Willy, Op 19-9-2018 om 7:36 schreef Willy Tarreau: Hi Pieter, I took some time this morning to give it a test. For now it fails here, after dumping 2200 lines of not really usable output that I didn't investigate. From what I'm seeing it seems to moderately stress the local machine so it

Re: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-18 Thread Willy Tarreau
Hi Pieter, On Sat, Sep 15, 2018 at 02:03:45AM +0200, PiBa-NL wrote: > Hi List, Willy, > > I've created a regtest that checks that when concurrent connections are > being handled that the connection counters are kept properly. > > I think it could be committed as attached. It takes a few seconds

[PATCH] REGTEST/MINOR: loadtest: add a test for connection counters

2018-09-14 Thread PiBa-NL
Date: Sat, 15 Sep 2018 01:51:54 +0200 Subject: [PATCH] REGTEST/MINOR: loadtest: add a test for connection counters after running 3000 requests in a loop --- reg-tests/loadtest/b0-loadtest.vtc | 94 ++ 1 file changed, 94 insertions(+) create mode 100644 reg-tests