Re: [PATCH] REGTESTS: converter: add url_dec test

2020-11-15 Thread William Dauchy
Hi Tim, thanks for the review. On Sun, Nov 15, 2020 at 1:50 PM Tim Düsterhus wrote: > Am 15.11.20 um 13:45 schrieb William Dauchy: > > +#REQUIRE_OPTION=OPENSSL > > I don't believe OPENSSL is required. The test passes for me even without > compiling with SSL. true bad copy/paste on my side. >

Re: [PATCH] REGTESTS: converter: add url_dec test

2020-11-15 Thread Tim Düsterhus
William, Am 15.11.20 um 13:45 schrieb William Dauchy: > +#REQUIRE_OPTION=OPENSSL I don't believe OPENSSL is required. The test passes for me even without compiling with SSL. > +client c1 -connect ${h1_fe_sock} { > + txreq -url "/bla+?foo%3Dbar%2B42+42" Maybe add %20 to the string to test

[PATCH] REGTESTS: converter: add url_dec test

2020-11-15 Thread William Dauchy
while looking at `url_dec` implementation I realised there was not yet a simple test to avoid future regressions. This one is testing simple case, including the "+" behaviour depending on the argument passed to `url_dec` Signed-off-by: William Dauchy --- reg-tests/converter/url_dec.vtc | 39