Re: [PATCH] cleanup coverity findging (make it silent)

well, I do not have an idea why extchk_setenv(check, EXTCHK_HAPROXY_SERVER_ADDR, check->argv[3]); is used instead of EXTCHK_SETENV(check, EXTCHK_HAPROXY_SERVER_ADDR, check->argv[3], err); it means, some environment variables are set in "best effort" mode, i.e. error is ignored. is it bad ?

Re: [PATCH] cleanup coverity findging (make it silent)

вт, 26 мая 2020 г. в 12:02, Willy Tarreau : > Hi Ilya, > > On Sat, May 23, 2020 at 03:47:58PM +0500, ??? wrote: > > From: Ilya Shipitsin > > Date: Sat, 23 May 2020 15:35:36 +0500 > > Subject: [PATCH] CLEANUP: src/checks.c: ignore return value using > DISGUISE(..) > > > > we do not want

Re: [PATCH] cleanup coverity findging (make it silent)

Hi Ilya, On Sat, May 23, 2020 at 03:47:58PM +0500, ??? wrote: > From: Ilya Shipitsin > Date: Sat, 23 May 2020 15:35:36 +0500 > Subject: [PATCH] CLEANUP: src/checks.c: ignore return value using DISGUISE(..) > > we do not want to check status of extchk_setenv, but static analyzsers >

[PATCH] cleanup coverity findging (make it silent)

Hello, let us clean up non important finding by wrapping it with DISGUISE(..) Cheers, Ilya Shipitcin From 7060a886a76452245ec466f6f7aaf28d504c9c3f Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 23 May 2020 15:35:36 +0500 Subject: [PATCH] CLEANUP: src/checks.c: ignore return value