Re: [PATCH] enable DEBUG_STRICT=1 for all kind of CI builds

2020-03-15 Thread Willy Tarreau 
On Sun, Mar 15, 2020 at 11:42:12AM +0100, William Lallemand wrote:
> On Sun, Mar 15, 2020 at 12:10:30PM +0500,  ??? wrote:
> > Hello,
> > 
> > I added DEBUG_STRICT=1 to all builds.
> > 
> > Ilya Shipitcin
> 
> > Subject: [PATCH] BUILD: CI: enable DEBUG_STRICT=1 for all kinds of CI builds
> 
> Hello Ilya,
> 
> Please use the "CI:" prefix from now, instead of "BUILD:".

And please oh please, a little bit of explanation in the commit message
about what it does and why! Here it can be something like :

  DEBUG_STRICT enables the BUG_ON() macro which validates some developers'
  assertions in the code that are not enabled for production build but
  may sometimes help catch certain rare bugs.

Also, please keep at least *one* build without DEBUG_STRICT (probably one
that we don't count on too much to run tests). The rationale here is that
if everyone builds with DEBUG_STRICT, we're at risk of leaving some
"unused variable" warnings in certain functions if some of them are tested
only by BUG_ON().

Thanks!
Willy

Re: [PATCH] enable DEBUG_STRICT=1 for all kind of CI builds

2020-03-15 Thread Martin Grigorov 
Hello,

I've just tested the change on my ARM64 VM and the build is successful!

Regards,
Martin

On Sun, Mar 15, 2020 at 9:12 AM Илья Шипицин  wrote:

> Hello,
>
> I added DEBUG_STRICT=1 to all builds.
>
> Ilya Shipitcin
>