Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-18 Thread Willy Tarreau
On Tue, May 18, 2021 at 12:07:17PM +0200, Tim Düsterhus wrote: > Ilya, > > On 5/18/21 11:50 AM, ??? wrote: > > I wonder if we can benefit from dependent steps, i.e. build VTest just once > > and deliver binary to other containers (instead of building it every time). > > > > The

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-18 Thread Tim Düsterhus
Ilya, On 5/18/21 11:50 AM, Илья Шипицин wrote: I wonder if we can benefit from dependent steps, i.e. build VTest just once and deliver binary to other containers (instead of building it every time). The complexity is not worth it to shave of another half second or so. Installing VTest is

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-18 Thread Илья Шипицин
вт, 18 мая 2021 г. в 13:54, Willy Tarreau : > On Sat, May 15, 2021 at 05:53:57PM +0200, Tim Düsterhus wrote: > > Willy, > > Ilya, > > > > On 5/15/21 8:58 AM, ??? wrote: > > > I attached a patch that uses "curl". on a distance it seems to be > faster > > > for 50% > > > > > > > This one

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-18 Thread Willy Tarreau
On Sat, May 15, 2021 at 05:53:57PM +0200, Tim Düsterhus wrote: > Willy, > Ilya, > > On 5/15/21 8:58 AM, ??? wrote: > > I attached a patch that uses "curl". on a distance it seems to be faster > > for 50% > > > > This one looks good to me. Now merged, thanks guys. A quick comment

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-15 Thread Tim Düsterhus
Willy, Ilya, On 5/15/21 8:58 AM, Илья Шипицин wrote: I attached a patch that uses "curl". on a distance it seems to be faster for 50% This one looks good to me. Best regards Tim Düsterhus

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-15 Thread Илья Шипицин
сб, 15 мая 2021 г. в 01:14, Илья Шипицин : > > > сб, 15 мая 2021 г. в 00:56, Nicolas CARPi : > >> > I compared several times, git clone is faster >> In my hands curl is the fastest option compared to git clone. >> > > ok, I'll make more comparison tomorrow > I attached a patch that uses "curl".

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-14 Thread Илья Шипицин
сб, 15 мая 2021 г. в 00:56, Nicolas CARPi : > > I compared several times, git clone is faster > In my hands curl is the fastest option compared to git clone. > ok, I'll make more comparison tomorrow > > Wouldn't "git clone --depth 1" be a good option to consider here? It > avoids getting the

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-14 Thread Nicolas CARPi
> I compared several times, git clone is faster In my hands curl is the fastest option compared to git clone. Wouldn't "git clone --depth 1" be a good option to consider here? It avoids getting the full history. ~Nico

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-14 Thread Илья Шипицин
сб, 15 мая 2021 г. в 00:20, Tim Düsterhus : > Ilya, > > On 5/14/21 9:02 PM, Илья Шипицин wrote: > > let us unify VTest installation magic. > > I disagree with using 'git clone' here, cloning the repository with full > history is wasteful. Please use the tarball approach from vtest.yml > I think,

Re: [PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-14 Thread Tim Düsterhus
Ilya, On 5/14/21 9:02 PM, Илья Шипицин wrote: let us unify VTest installation magic. I disagree with using 'git clone' here, cloning the repository with full history is wasteful. Please use the tarball approach from vtest.yml Best regards Tim Düsterhus

[PATCH] move VTest installation to scripts/build-vtest.sh

2021-05-14 Thread Илья Шипицин
Hello, let us unify VTest installation magic. Ilya From 9f85fe25ad9ee6bf753311a44a5089a6ee2096c9 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 14 May 2021 23:59:35 +0500 Subject: [PATCH] CI: introduce scripts/build-vtest.sh for installing VTest we install VTest for all CI systems,