Re: [PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-25 Thread Willy Tarreau
Hi guys, On Mon, Jan 22, 2018 at 08:13:59AM +0200, Jarno Huuskonen wrote: > I did some brief testing on saturday and with this silly config > frontend test4 > bind ipv4@127.0.0.1:8080 > bind ipv6@::1:8080 > > http-request track-sc1 src,ipmask(32,128) table test_be > >

Re: [PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-21 Thread Jarno Huuskonen
Hi, On Sun, Jan 21, Tim Düsterhus wrote: > Jarno, > > Am 15.01.2018 um 14:28 schrieb Jarno Huuskonen: > > I'll try to test later (might be couple of days). > > Did you find time, yet? I did some brief testing on saturday and with this silly config frontend test4 bind

Re: [PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-21 Thread Tim Düsterhus
Jarno, Willy, Am 15.01.2018 um 14:28 schrieb Jarno Huuskonen: > On Sun, Jan 14, Tim Düsterhus wrote: >>> Have you tested that req.hdr_ip / stick tables work w/both masks ? I >>> used something like: >>> http-request track-sc0 req.hdr_ip(X,1),ipmask(24,64) table test_be >>> http-request

Re: [PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-21 Thread Tim Düsterhus
Willy, Am 21.01.2018 um 14:07 schrieb Willy Tarreau: > There's no problem here because these ones are word-aligned anyway. > There are other such occurrences elsewhere in the code, so don't > worry for this one. Okay, I sent an updated patch that uses the cast to uint32_t. > From what I've seen

Re: [PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-21 Thread Willy Tarreau
Hi Tim, On Sun, Jan 21, 2018 at 01:24:06PM +0100, Tim Düsterhus wrote: > Jarno, > > Am 15.01.2018 um 14:28 schrieb Jarno Huuskonen: > > I'll try to test later (might be couple of days). > > Did you find time, yet? > > > I'll get a compilation error on centos7: > > src/sample.c: In function

Re: [PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-21 Thread Tim Düsterhus
Jarno, Am 15.01.2018 um 14:28 schrieb Jarno Huuskonen: > I'll try to test later (might be couple of days). Did you find time, yet? > I'll get a compilation error on centos7: > src/sample.c: In function ‘sample_conv_ipmask’: > src/sample.c:1623:3: error: ‘for’ loop initial declarations are only

Re: [PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-15 Thread Jarno Huuskonen
Hi Tim, On Sun, Jan 14, Tim Düsterhus wrote: > > Have you tested that req.hdr_ip / stick tables work w/both masks ? I > > used something like: > > http-request track-sc0 req.hdr_ip(X,1),ipmask(24,64) table test_be > > http-request set-var(sess.myx) req.hdr_ip(X,1),ipmask(24,64) > > http-response

Re: [PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-14 Thread Tim Düsterhus
Jarno, Am 14.01.2018 um 10:01 schrieb Jarno Huuskonen: > Quick question: how does your patch handle ipv4mapped ipv6 > address(:::1.2.3.4) ? Does it use v4 or v6 mask for these addresses ? > (From code I think v4 (first tries to convert v6 to v4 with c_ipv62ip) ?) Yes, you are correct. I

Re: [PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-14 Thread Jarno Huuskonen
Hi, On Sat, Jan 13, Tim Duesterhus wrote: > this is a patch series ultimately leading to IPv6 support for the > ipmask converter. Please note the following: +1 I did something similar (never 100% finished) (http://haproxy.formilux.narkive.com/PZHJ5xNH/rfc-ipv6mask-converter). Quick question:

Re: [PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-13 Thread Tim Düsterhus
Hi please forgive my messed up threading, I misconfigured the rate limiting on my mailserver and a few emails could not be sent on the first try and while resending I must have made an error while manually setting the message headers. I can resend if anything is missing or not looking good.

[PATCH 0/8] Add IPv6 support to the ipmask converter

2018-01-13 Thread Tim Duesterhus
Hi this is a patch series ultimately leading to IPv6 support for the ipmask converter. Please note the following: - The first patch contains non-US-ASCII characters, as the sole purpose of it is to remove the non-US-ASCII characters from the source file. Please take extra care when applying