Re: [PATCH 1/6] MINOR: spoa: allow MAX_FRAME_SIZE override

2020-09-02 Thread Gilchrist DADAGLO
Thanks Christopher,
Appreciate the fast merge.
Gilchrist

On Tue, Sep 1, 2020, 18:36 Christopher Faulet  wrote:

> Le 24/08/2020 à 21:21, gilchr...@dadaglo.com a écrit :
> > From: Bertrand Jacquin 
> >
> > MAX_FRAME_SIZE is forced to the default value of tune.bufsize, however
> > they don't necessarily have to be tight together.
> > ---
> >   contrib/spoa_server/spoa.h | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/contrib/spoa_server/spoa.h b/contrib/spoa_server/spoa.h
> > index 8f912e4..8d6d4be 100644
> > --- a/contrib/spoa_server/spoa.h
> > +++ b/contrib/spoa_server/spoa.h
> > @@ -17,7 +17,10 @@
> >   #include 
> >   #include 
> >
> > +#ifndef MAX_FRAME_SIZE
> >   #define MAX_FRAME_SIZE16384
> > +#endif
> > +
> >   #define SPOP_VERSION  "2.0"
> >   #define SPOA_CAPABILITIES ""
> >
> >
>
> All the series applied ! I've relabeled patches as part of
> "contrib/spoa-server"
> and I've mentioned that all fixes must be backported as far as 2.0.
>
> Thanks,
> --
> Christopher Faulet
>


Re: [PATCH 1/6] MINOR: spoa: allow MAX_FRAME_SIZE override

2020-09-01 Thread Christopher Faulet

Le 24/08/2020 à 21:21, gilchr...@dadaglo.com a écrit :

From: Bertrand Jacquin 

MAX_FRAME_SIZE is forced to the default value of tune.bufsize, however
they don't necessarily have to be tight together.
---
  contrib/spoa_server/spoa.h | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/contrib/spoa_server/spoa.h b/contrib/spoa_server/spoa.h
index 8f912e4..8d6d4be 100644
--- a/contrib/spoa_server/spoa.h
+++ b/contrib/spoa_server/spoa.h
@@ -17,7 +17,10 @@
  #include 
  #include 
  
+#ifndef MAX_FRAME_SIZE

  #define MAX_FRAME_SIZE16384
+#endif
+
  #define SPOP_VERSION  "2.0"
  #define SPOA_CAPABILITIES ""
  



All the series applied ! I've relabeled patches as part of "contrib/spoa-server" 
and I've mentioned that all fixes must be backported as far as 2.0.


Thanks,
--
Christopher Faulet



[PATCH 1/6] MINOR: spoa: allow MAX_FRAME_SIZE override

2020-08-24 Thread gilchrist
From: Bertrand Jacquin 

MAX_FRAME_SIZE is forced to the default value of tune.bufsize, however
they don't necessarily have to be tight together.
---
 contrib/spoa_server/spoa.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/contrib/spoa_server/spoa.h b/contrib/spoa_server/spoa.h
index 8f912e4..8d6d4be 100644
--- a/contrib/spoa_server/spoa.h
+++ b/contrib/spoa_server/spoa.h
@@ -17,7 +17,10 @@
 #include 
 #include 
 
+#ifndef MAX_FRAME_SIZE
 #define MAX_FRAME_SIZE16384
+#endif
+
 #define SPOP_VERSION  "2.0"
 #define SPOA_CAPABILITIES ""
 
-- 
2.24.3.AMZN