Re: [PATCH 2/3] MINOR: stream: Add stream_generate_unique_id function

2020-02-27 Thread Tim Düsterhus
Willy, Am 27.02.20 um 03:49 schrieb Willy Tarreau: >> +int stream_generate_unique_id(struct stream *strm, struct list *format) { > > Please put the function's opening brace on its own line. The reason for > this is when you have many arguments and variables, it easily becomes a > mess where you c

Re: [PATCH 2/3] MINOR: stream: Add stream_generate_unique_id function

2020-02-26 Thread Willy Tarreau
On Wed, Feb 26, 2020 at 04:20:50PM +0100, Tim Duesterhus wrote: > Currently unique IDs for a stream are generated using repetitive code in > multiple locations, possibly allowing for inconsistent behavior. Just a few minor coding style comments : > +int stream_generate_unique_id(struct stream *st

[PATCH 2/3] MINOR: stream: Add stream_generate_unique_id function

2020-02-26 Thread Tim Duesterhus
Currently unique IDs for a stream are generated using repetitive code in multiple locations, possibly allowing for inconsistent behavior. --- include/proto/stream.h | 3 +++ src/http_ana.c | 1 - src/stream.c | 19 +++ 3 files changed, 22 insertions(+), 1 deleti