Dear list! Author: Samuel Maftoul <samuel.maft...@gmail.com> Number of patches: 2
This is an automated relay of the Github pull request: Allow "no option forwardfor" Patch title(s): [WIP] allow "no option forwardfor" Require both frontend and backend to have option forwardfor to enable it Link: https://github.com/haproxy/haproxy/pull/1853 Edit locally: wget https://github.com/haproxy/haproxy/pull/1853.patch && vi 1853.patch Apply locally: curl https://github.com/haproxy/haproxy/pull/1853.patch | git am - Description: Fixes #130 * Move the `forwardfor` logic before we check the negation of options ( https://github.com/haproxy/haproxy/blob/94f763b5 e4b2aafd2c6d65f074fdc28735556f25/src/cfgparse-listen.c#L2071 ) so we can negate it. * Add logic to differentiate KWM_NO and KWM_STD so we modify options for the proxy. * Modify logic to include the header only if both frontend and backend have the header enabled. About this last point (and the 2nd commit of this PR) , I'm not sure it's what I'm supposed to do. Maybe I should also some `no_options` logic to properly disable the header in the backend ? Also, this PR so far is missing docs, but I want the logic to be clear before writing the document (or should it be done the other way around ?). Finally, it may also miss some tests, should I add them to htt ps://github.com/haproxy/haproxy/blob/025945f12cde56dde22baec286393fd1f 048c0fc/reg-tests/http-rules/except-forwardfor-originalto.vtc ? Instructions: This github pull request will be closed automatically; patch should be reviewed on the haproxy mailing list (haproxy@formilux.org). Everyone is invited to comment, even the patch's author. Please keep the author and list CCed in replies. Please note that in absence of any response this pull request will be lost.
