Re: [PR] Prevent favicon.ico requests errors for stats page.

2020-08-19 Thread Willy Tarreau
Hi,

On Tue, Aug 18, 2020 at 10:23:08AM +0200, PR Bot wrote:
> Patch title(s): 
>Prevent favicon.ico requests for stats page
>Merge pull request #1 from zurikus/zurikus-patch-1

Thank you for this! I didn't even know it was possible to prevent the
browser from requesting this file and it has been annoying me as well.
Tested and confirmed, thus merged :-)

Thanks!
Willy



[PR] Prevent favicon.ico requests errors for stats page.

2020-08-18 Thread PR Bot
Dear list!

Author: zurikus 
Number of patches: 2

This is an automated relay of the Github pull request:
   Prevent favicon.ico requests errors for stats page.

Patch title(s): 
   Prevent favicon.ico requests for stats page
   Merge pull request #1 from zurikus/zurikus-patch-1

Link:
   https://github.com/haproxy/haproxy/pull/824

Edit locally:
   wget https://github.com/haproxy/haproxy/pull/824.patch && vi 824.patch

Apply locally:
   curl https://github.com/haproxy/haproxy/pull/824.patch | git am -

Description:
   Prevent favicon.ico requests errors for stats page.
   
   Haproxy
   stats page don't have a favicon.ico, but browsers make a request for
   it.
   This lead to errors during stats page requests:
   
   Aug
   18 08:46:41 somehost.example.net haproxy[1521534]: X.X.X.X:61403
   [18/Aug/2020:08:46:41.437] stats stats/ -1/-1/-1/-1/0 503 222 - - SC--
   2/2/0/0/0 0/0 "GET /favicon.ico HTTP/1.1"
   Aug 18 08:46:42
   somehost.example.net haproxy[1521534]: X.X.X.X:61403
   [18/Aug/2020:08:46:42.650] stats stats/ -1/-1/-1/-1/0 503 222 - - SC--
   2/2/0/0/0 0/0 "GET /favicon.ico HTTP/1.1"
   
   Patch provided set
   empty favicon.ico for haproxy stats page.

Instructions:
   This github pull request will be closed automatically; patch should be
   reviewed on the haproxy mailing list (haproxy@formilux.org). Everyone is
   invited to comment, even the patch's author. Please keep the author and
   list CCed in replies. Please note that in absence of any response this
   pull request will be lost.