Re: Patch with some small memory usage fixes

2014-05-15 Thread Willy Tarreau
Hi Dirkjan, On Wed, May 14, 2014 at 03:08:23PM +0200, Dirkjan Bussink wrote: On 02 May 2014, at 11:37, Willy Tarreau w...@1wt.eu wrote: That said, one of your fix introduces a bug here : diff --git a/src/haproxy.c b/src/haproxy.c index ed2ff21..c1ec783 100644 --- a/src/haproxy.c

Re: Patch with some small memory usage fixes

2014-05-14 Thread Dirkjan Bussink
On 02 May 2014, at 11:37, Willy Tarreau w...@1wt.eu wrote: That said, one of your fix introduces a bug here : diff --git a/src/haproxy.c b/src/haproxy.c index ed2ff21..c1ec783 100644 --- a/src/haproxy.c +++ b/src/haproxy.c @@ -1607,6 +1607,7 @@ int main(int argc, char **argv)

Re: Patch with some small memory usage fixes

2014-05-02 Thread Willy Tarreau
Hi Dirkjan, On Mon, Apr 28, 2014 at 04:00:18PM -0700, Dirkjan Bussink wrote: Hi all, When building HAProxy using the Clang Static Analyzer, it found a few cases of invalid memory usage and leaks. I?ve attached a patch to fix these cases. I think there are 3 types of errors fixed by your

Re: Patch with some small memory usage fixes

2014-04-29 Thread Dmitry Sivachenko
Hello, if (groups) free(groups); I think these checks are redundant, because according to free(3): -- If ptr is NULL, no action occurs. On 29 апр. 2014 г., at 3:00, Dirkjan Bussink d.buss...@gmail.com wrote: Hi all, When building HAProxy using the Clang Static Analyzer, it found a few

Patch with some small memory usage fixes

2014-04-28 Thread Dirkjan Bussink
Hi all, When building HAProxy using the Clang Static Analyzer, it found a few cases of invalid memory usage and leaks. I’ve attached a patch to fix these cases. — Regards, Dirkjan Bussink 0001-Fix-a-few-memory-usage-errors.patch Description: Binary data