Re: dev18 splice-auto

2013-04-06 Thread Willy Tarreau
On Sat, Apr 06, 2013 at 08:22:23PM +0200, Sander Klein wrote: > On 06.04.2013 11:50, Willy Tarreau wrote: > >Hi Sander, > > > >the patch I proposed was not enough, it only fixed a few of the > >occurrences. The issue was introduced in dev12 with the connection > >rework. > > > >Please use the attac

Re: dev18 splice-auto

2013-04-06 Thread Sander Klein
On 06.04.2013 11:50, Willy Tarreau wrote: Hi Sander, the patch I proposed was not enough, it only fixed a few of the occurrences. The issue was introduced in dev12 with the connection rework. Please use the attached patch, which I have tested to fix the issue here and merged. The issue mainl

Re: dev18 splice-auto

2013-04-06 Thread Sander Klein
Heh, I didn't have time to test the previous one, but I'll test this one this evening. Greets, Sander On 6 apr. 2013, at 11:50, Willy Tarreau wrote: > Hi Sander, > > the patch I proposed was not enough, it only fixed a few of the > occurrences. The issue was introduced in dev12 with the con

Re: dev18 splice-auto

2013-04-06 Thread Willy Tarreau
Hi Sander, the patch I proposed was not enough, it only fixed a few of the occurrences. The issue was introduced in dev12 with the connection rework. Please use the attached patch, which I have tested to fix the issue here and merged. The issue mainly happens with chunked-encoded responses where

Re: dev18 splice-auto

2013-04-05 Thread Willy Tarreau
Hi Sander, On Fri, Apr 05, 2013 at 02:51:54PM +0200, Sander Klein wrote: > Hi Lukas, > > On 05.04.2013 12:00, Lukas Tribus wrote: > >Whats is the percentage of requests failing this way? > > I'm not sure. But I think it's less than 1%. We do a couple of 100's > request per second and about ever

RE: dev18 splice-auto

2013-04-05 Thread Lukas Tribus
> It is possible to do that, but only if really necessary. And I probably > only want to share that with direct HAProxy developers. No problem with that; but we need to get more informations somehow and I have the feeling that this is hard to reproduce ... Can you give us the output of the failed

RE: dev18 splice-auto

2013-04-05 Thread Sander Klein
Hi Lukas, On 05.04.2013 12:00, Lukas Tribus wrote: Whats is the percentage of requests failing this way? I'm not sure. But I think it's less than 1%. We do a couple of 100's request per second and about every second I see one failed request. Do you know if this is an issue introduced by a c

RE: dev18 splice-auto

2013-04-05 Thread Lukas Tribus
Hi Sander, I don't recall any open issues with splicing on the ML; here a few questions to pinpoint the issue: Whats is the percentage of requests failing this way? Do you know if this is an issue introduced by a certain haproxy build, and thus was working previously, or did you only recently en