Re: struggling with TCP Fast Open (tfo bind option)

2013-04-02 Thread Willy Tarreau
Hi Lukas, On Tue, Apr 02, 2013 at 03:14:12PM +0200, Lukas Tribus wrote: > > > So do you think it would make sense to introduce a new build flag for TFO > > > and define TCP_FASTOPEN? > > > > > > This would be similar to USE_TPROXY, USE_LINUX_SPLICE or USE_ACCEPT4 I > > > guess. > > > > > > That w

RE: struggling with TCP Fast Open (tfo bind option)

2013-04-02 Thread Lukas Tribus
> > So do you think it would make sense to introduce a new build flag for TFO > > and define TCP_FASTOPEN? > > > > This would be similar to USE_TPROXY, USE_LINUX_SPLICE or USE_ACCEPT4 I > > guess. > > > > That way, users have a documented way to enable TFO with current libc's? > > Yes, that's an i

Re: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Willy Tarreau
On Wed, Feb 13, 2013 at 11:42:27PM +0100, Lukas Tribus wrote: > > > > If you want I can send patches, but I will have to fix the mailer first. > > > > Yes, please do ! > > The attached patch fixes the doc/code comments and should reach you > without being mangled. Done, thank you Lukas! Willy

RE: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Lukas Tribus
> > If you want I can send patches, but I will have to fix the mailer first. > > Yes, please do ! The attached patch fixes the doc/code comments and should reach you without being mangled. Lukas 0001-DOC-tfo-bump-required-kernel-to-linux-3.7.patch De

Re: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Willy Tarreau
On Wed, Feb 13, 2013 at 04:26:24PM +0100, Lukas Tribus wrote: > > > Anyway I'm used not to rely on libcs found in the field because many > > users upgrade their kernels on supported distros. That's why there are so > > many defines in the makefile ! > > So do you think it would make sense to intr

RE: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Lukas Tribus
> Anyway I'm used not to rely on libcs found in the field because many > users upgrade their kernels on supported distros. That's why there are so > many defines in the makefile ! So do you think it would make sense to introduce a new build flag for TFO and define TCP_FASTOPEN? This would be sim

Re: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Willy Tarreau
On Wed, Feb 13, 2013 at 09:40:31AM +0100, Lukas Tribus wrote: > Looks like glibc only has support for TCP_FASTOPEN in the unreleased 2.18 > version [1] and I'm using glibc 2.15 here. OK. Anyway I'm used not to rely on libcs found in the field because many users upgrade their kernels on supported d

RE: struggling with TCP Fast Open (tfo bind option)

2013-02-13 Thread Lukas Tribus
> Huh ? It is already present a few lines above : Correct, I was just confused about it because the other keywords like defer-accept or v4v6 are also present twice and tfo was missing below the comment: /* the versions with the NULL parse function*/. lukas@ubuntuvm:~/haproxy-ss-20130125/src$ gr

Re: struggling with TCP Fast Open (tfo bind option)

2013-02-12 Thread Willy Tarreau
Hi Lukas, On Wed, Feb 13, 2013 at 01:03:40AM +0100, Lukas Tribus wrote: > > Hi Willy, > > I tried to enable tfo on the bind line today, however, it failed even on > recent kernels for me. > > At first it was failing with: > [ALERT] 042/223418 (1141) : parsing [haproxy.cfg:14] : 'bind *:1234' un