Re: SSL: double free on reload

2018-07-18 Thread Willy Tarreau
On Tue, Jul 17, 2018 at 01:49:40PM +0200, Thierry Fournier wrote: > > Could you guys please give it a try to confirm ? I'll then merge it. > > > i, the patch works for me with backport to the 1.8 version. It is on > productio stage. OK thank you Thierry, now merged. Willy

Re: SSL: double free on reload

2018-07-17 Thread Thierry Fournier
On Tue, 17 Jul 2018 10:10:58 +0200 Willy Tarreau wrote: > Hi again Nenad, > > On Tue, Jul 17, 2018 at 05:18:45AM +0200, Willy Tarreau wrote: > > Hi Nenad, > > > > On Tue, Jul 17, 2018 at 03:37:37AM +0200, Nenad Merdanovic wrote: > > > Ugh, this was a long time ago. [FROM MEMORY] The element

Re: SSL: double free on reload

2018-07-17 Thread Willy Tarreau
Hi again Nenad, On Tue, Jul 17, 2018 at 05:18:45AM +0200, Willy Tarreau wrote: > Hi Nenad, > > On Tue, Jul 17, 2018 at 03:37:37AM +0200, Nenad Merdanovic wrote: > > Ugh, this was a long time ago. [FROM MEMORY] The element should not be > > duplicated as far as I can remember. The references are

Re: SSL: double free on reload

2018-07-16 Thread Willy Tarreau
Hi Nenad, On Tue, Jul 17, 2018 at 03:37:37AM +0200, Nenad Merdanovic wrote: > Ugh, this was a long time ago. [FROM MEMORY] The element should not be > duplicated as far as I can remember. The references are stored in an ebtree > in order to prevent duplication and to provide consistent view when

Re: SSL: double free on reload

2018-07-16 Thread Nenad Merdanovic
Hello, On 7/16/2018 10:46 AM, Willy Tarreau wrote: On Mon, Jul 16, 2018 at 08:32:31AM +0200, Janusz Dziemidowicz wrote: pon., 16 lip 2018 o 08:02 Willy Tarreau napisal(a): This one looks a bit strange. I looked at it a little bit and it corresponds to the line

Re: SSL: double free on reload

2018-07-16 Thread Willy Tarreau
On Mon, Jul 16, 2018 at 08:32:31AM +0200, Janusz Dziemidowicz wrote: > pon., 16 lip 2018 o 08:02 Willy Tarreau napisal(a): > > This one looks a bit strange. I looked at it a little bit and it corresponds > > to the line "free(bind_conf->keys_ref->tlskeys);". Unfortunately, there is > > no > >

Re: SSL: double free on reload

2018-07-16 Thread Thierry Fournier
On Mon, 16 Jul 2018 08:00:48 +0200 Willy Tarreau wrote: > Hi Thierry, > > On Fri, Jul 06, 2018 at 04:28:22PM +0200, Thierry Fournier wrote: > > Hi list, > > > > I caught a double-free whien I reload haproxy-1.8: > > > > writev(2, [{"*** Error in `", 14}, {"/opt/o3-haproxy/sbin/haproxy",

Re: SSL: double free on reload

2018-07-16 Thread Janusz Dziemidowicz
pon., 16 lip 2018 o 08:02 Willy Tarreau napisaƂ(a): > This one looks a bit strange. I looked at it a little bit and it corresponds > to the line "free(bind_conf->keys_ref->tlskeys);". Unfortunately, there is no > other line in the code appearing to perfom a free on this element, and when >

Re: SSL: double free on reload

2018-07-16 Thread Willy Tarreau
Hi Thierry, On Fri, Jul 06, 2018 at 04:28:22PM +0200, Thierry Fournier wrote: > Hi list, > > I caught a double-free whien I reload haproxy-1.8: > > writev(2, [{"*** Error in `", 14}, {"/opt/o3-haproxy/sbin/haproxy", 28}, > {"': ", 3}, {"double free or corruption (!prev)", 33}, {": 0x", 4},

SSL: double free on reload

2018-07-06 Thread Thierry Fournier
Hi list, I caught a double-free whien I reload haproxy-1.8: writev(2, [{"*** Error in `", 14}, {"/opt/o3-haproxy/sbin/haproxy", 28}, {"': ", 3}, {"double free or corruption (!prev)", 33}, {": 0x", 4}, {"1cec2ab0", 16}, {" ***\n", 5}], 7) = 103 Decoded: *** Error in