Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-20 Thread Willy Tarreau
On Fri, Jul 20, 2018 at 09:56:23PM +0200, PiBa-NL wrote: > Thanks Christopher & Willy, > > Op 20-7-2018 om 14:26 schreef Willy Tarreau: > > > Op 20-7-2018 om 10:43 schreef Christopher Faulet: > > OK finally I've merged it because it obviously fixes a bug. > > Willy > > Confirmed fixed with

Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-20 Thread PiBa-NL
Thanks Christopher & Willy, Op 20-7-2018 om 14:26 schreef Willy Tarreau: Op 20-7-2018 om 10:43 schreef Christopher Faulet: OK finally I've merged it because it obviously fixes a bug. Willy Confirmed fixed with current master's: HA-Proxy version 1.8.12-5e100b4 2018/07/20 HA-Proxy version

Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-20 Thread Willy Tarreau
On Fri, Jul 20, 2018 at 10:43:13AM +0200, Christopher Faulet wrote: > Damn! I forgot to check that. We talked about it 30 min ago though! OK finally I've merged it because it obviously fixes a bug and William wants to prepare another release which I think is a good idea. We can revisit this later

Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-20 Thread Christopher Faulet
Le 20/07/2018 à 10:38, Willy Tarreau a écrit : On Fri, Jul 20, 2018 at 10:27:42AM +0200, Christopher Faulet wrote: In thread_sync_barrier, we exit when all threads have set their own bit in the barrier mask. It is done by comparing it to all_threads_mask. But we must not use a simple equality

Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-20 Thread Willy Tarreau
On Fri, Jul 20, 2018 at 10:27:42AM +0200, Christopher Faulet wrote: > In thread_sync_barrier, we exit when all threads have set their own bit in the > barrier mask. It is done by comparing it to all_threads_mask. But we must not > use a simple equality to do so, becaue all_threads_mask may change.

Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-20 Thread Christopher Faulet
Le 17/07/2018 à 19:39, PiBa-NL a écrit : Hi Christopher, Op 17-7-2018 om 10:09 schreef Christopher Faulet: Could you try to revert the following commit please ?  * ba86c6c25 MINOR: threads: Be sure to remove threads from all_threads_mask on exit Without this specific commit the termination

Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-17 Thread PiBa-NL
Hi Christopher, Op 17-7-2018 om 10:09 schreef Christopher Faulet: Could you try to revert the following commit please ?  * ba86c6c25 MINOR: threads: Be sure to remove threads from all_threads_mask on exit Without this specific commit the termination of the old process works 'properly'.

Re: haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-17 Thread Christopher Faulet
Le 17/07/2018 à 01:08, PiBa-NL a écrit : Hi List, With a build of 1.8.12 (and the 1.9 snapshot of 20180623 ) im getting the 'old' haproxy process take up 100% cpu usage when using 3 threads in the config and reloading with -sf parameter. I'm using FreeBSD.. (It also happens with the 14-7

haproxy 1.8.12 / 1.9- 20180623 / stopping process hangs with threads (100% cpu) on -sf reload / FreeBSD

2018-07-16 Thread PiBa-NL
Hi List, With a build of 1.8.12 (and the 1.9 snapshot of 20180623 ) im getting the 'old' haproxy process take up 100% cpu usage when using 3 threads in the config and reloading with -sf parameter. I'm using FreeBSD.. (It also happens with the 14-7 snapshot.) It seems to happen after 1