Re: resolvers - resolv.conf fallback

2018-04-17 Thread Ben Draut
Yep, will do. On Tue, Apr 17, 2018 at 8:04 AM, Baptiste wrote: > > On Sat, Apr 14, 2018 at 5:39 AM, Jonathan Matthews < > cont...@jpluscplusm.com> wrote: > >> On 14 April 2018 at 05:13, Willy Tarreau wrote: >> > On Fri, Apr 13, 2018 at 03:48:19PM -0600, Ben Draut

Re: resolvers - resolv.conf fallback

2018-04-17 Thread Baptiste
On Sat, Apr 14, 2018 at 5:39 AM, Jonathan Matthews wrote: > On 14 April 2018 at 05:13, Willy Tarreau wrote: > > On Fri, Apr 13, 2018 at 03:48:19PM -0600, Ben Draut wrote: > >> How about 'parse-resolv-conf' for the current feature, and we reserve > >>

Re: resolvers - resolv.conf fallback

2018-04-14 Thread Jonathan Matthews
On 14 April 2018 at 05:13, Willy Tarreau wrote: > On Fri, Apr 13, 2018 at 03:48:19PM -0600, Ben Draut wrote: >> How about 'parse-resolv-conf' for the current feature, and we reserve >> 'use-system-resolvers' for the feature that Jonathan described? > > Perfect! "parse" is quite

Re: resolvers - resolv.conf fallback

2018-04-13 Thread Willy Tarreau
On Fri, Apr 13, 2018 at 03:48:19PM -0600, Ben Draut wrote: > How about 'parse-resolv-conf' for the current feature, and we reserve > 'use-system-resolvers' for the feature that Jonathan described? Perfect! "parse" is quite explicit at least! Willy

Re: resolvers - resolv.conf fallback

2018-04-13 Thread Ben Draut
How about 'parse-resolv-conf' for the current feature, and we reserve 'use-system-resolvers' for the feature that Jonathan described? On Fri, Apr 13, 2018 at 3:46 PM, Willy Tarreau wrote: > Hi Jonathan, > > On Fri, Apr 13, 2018 at 09:24:54PM +, Jonathan Matthews wrote: > > On

Re: resolvers - resolv.conf fallback

2018-04-13 Thread Willy Tarreau
Hi Jonathan, On Fri, Apr 13, 2018 at 09:24:54PM +, Jonathan Matthews wrote: > On Fri, 13 Apr 2018 at 15:09, Willy Tarreau wrote: > > > On Fri, Apr 13, 2018 at 08:01:13AM -0600, Ben Draut wrote: > > > How about this: > > > > > > * New directive: 'use_system_nameservers' > > > >

Re: resolvers - resolv.conf fallback

2018-04-13 Thread Jonathan Matthews
On Fri, 13 Apr 2018 at 15:09, Willy Tarreau wrote: > On Fri, Apr 13, 2018 at 08:01:13AM -0600, Ben Draut wrote: > > How about this: > > > > * New directive: 'use_system_nameservers' > > OK, just use dashes ('-') instead of underscores as this is what we mostly > use on other

Re: resolvers - resolv.conf fallback

2018-04-13 Thread Willy Tarreau
On Fri, Apr 13, 2018 at 08:01:13AM -0600, Ben Draut wrote: > How about this: > > * New directive: 'use_system_nameservers' OK, just use dashes ('-') instead of underscores as this is what we mostly use on other keywords, except a few historical mistakes. > * Parse /etc/resolv.conf for

Re: resolvers - resolv.conf fallback

2018-04-13 Thread Ben Draut
How about this: * New directive: 'use_system_nameservers' * Parse /etc/resolv.conf for nameservers when new directive is seen when parsing resolvers. * Make check_config_validity issue a warning for each resolvers section that has an empty nameservers list. Thoughts? On Tue, Apr 10, 2018 at

Re: resolvers - resolv.conf fallback

2018-04-10 Thread Ben Draut
I agree. On Mon, Apr 9, 2018 at 1:35 AM, Baptiste wrote: > > > On Fri, Apr 6, 2018 at 4:54 PM, Willy Tarreau wrote: > >> On Fri, Apr 06, 2018 at 04:50:54PM +0200, Lukas Tribus wrote: >> > > Well, sometimes when you're debugging a configuration, it's nice to be >>

Re: resolvers - resolv.conf fallback

2018-04-09 Thread Baptiste
On Fri, Apr 6, 2018 at 4:54 PM, Willy Tarreau wrote: > On Fri, Apr 06, 2018 at 04:50:54PM +0200, Lukas Tribus wrote: > > > Well, sometimes when you're debugging a configuration, it's nice to be > > > able to disable some elements. Same for those manipulating/building > > > configs

Re: resolvers - resolv.conf fallback

2018-04-06 Thread Willy Tarreau
On Fri, Apr 06, 2018 at 04:50:54PM +0200, Lukas Tribus wrote: > > Well, sometimes when you're debugging a configuration, it's nice to be > > able to disable some elements. Same for those manipulating/building > > configs by assembling elements and iteratively pass them through > > "haproxy -c".

Re: resolvers - resolv.conf fallback

2018-04-06 Thread Lukas Tribus
Hello Willy, On 6 April 2018 at 14:14, Willy Tarreau wrote: >> The confusion often arises because haproxy accepts a resolver >> configuration where no resolvers are configured. Maybe we should >> reject the configuration when a resolver is referred to in the servers >> lines, but

Re: resolvers - resolv.conf fallback

2018-04-06 Thread Willy Tarreau
Hi Lukas, On Fri, Apr 06, 2018 at 12:33:14PM +0200, Lukas Tribus wrote: > On 6 April 2018 at 11:14, Willy Tarreau wrote: > >> I don't think we need a new config know. > > > > Just thinking, is the goal *not to have to* configure "resolve" on > > server lines in this case, or to

Re: resolvers - resolv.conf fallback

2018-04-06 Thread Lukas Tribus
Hi Willy, On 6 April 2018 at 11:14, Willy Tarreau wrote: >> I don't think we need a new config know. > > Just thinking, is the goal *not to have to* configure "resolve" on > server lines in this case, or to avoid having to pre-configure the > resolvers themselves when they're the

Re: resolvers - resolv.conf fallback

2018-04-06 Thread Willy Tarreau
Hi guys, On Wed, Apr 04, 2018 at 12:32:41PM +0200, Lukas Tribus wrote: > Hello Baptiste, > > > > - (for Lukas) what do you think is better, a configuration option to trigger > > parsing of resolv.conf or as proposed, if no nameserver are found, we use > > resolv.conf as a failback? > > > I

Re: resolvers - resolv.conf fallback

2018-04-04 Thread Lukas Tribus
Hello Baptiste, > - (for Lukas) what do you think is better, a configuration option to trigger > parsing of resolv.conf or as proposed, if no nameserver are found, we use > resolv.conf as a failback? I don't think we need a config knob for this; currently we don't do anything when no

Re: resolvers - resolv.conf fallback

2018-04-03 Thread Baptiste
On Mon, Apr 2, 2018 at 5:09 PM, Ben Draut wrote: > Assuming no one else is already working on the feature, I'd like to > contribute > the change to have the resolvers section fall back to parsing > /etc/resolv.conf > when no nameserver directives are present. > > This was

resolvers - resolv.conf fallback

2018-04-02 Thread Ben Draut
Assuming no one else is already working on the feature, I'd like to contribute the change to have the resolvers section fall back to parsing /etc/resolv.conf when no nameserver directives are present. This was previously discussed here: https://www.mail-