[PATCH] BUG/MINOR: lua: Bad HTTP client request duration.

2018-08-24 Thread Frederic Lecaille
Here is a patch to fix the issue reported by Patrick in this thread (BUG: Tw is negative with lua sleep https://www.mail-archive.com/haproxy@formilux.org/msg30474.html). Note that I provide a reg testing file to test both HTTP and TCP LUA applet callbacks used when registering an HTTP or TCP

Re: Issue with TCP splicing

2018-08-24 Thread Lukas Tribus
Hello Julien, On Thu, 23 Aug 2018 at 20:49, Julien Semaan wrote: > > Hi Olivier, > > Sorry for the delay, obtaining the core dump from a production environment > was a bit tricky. > > So, I have attached the core dump to this email. I hope this will help you > identify the issue. The

Re: [PATCH] BUG/MINOR: lua: Bad HTTP client request duration.

2018-08-24 Thread Frederic Lecaille
On 08/24/2018 08:42 AM, Frederic Lecaille wrote: Here is a patch to fix the issue reported by Patrick in this thread (BUG: Tw is negative with lua sleep https://www.mail-archive.com/haproxy@formilux.org/msg30474.html). Note that I provide a reg testing file to test both HTTP and TCP LUA

Re: Clarification re Timeouts and Session State in the Logs

2018-08-24 Thread Aleksandar Lazic
Hi. Am 24.08.2018 um 11:04 schrieb Daniel Schneller: > Hi! > > Thanks for that input. I would like to understand what's going before making > changes. :) There is a how-it-works.txt

Re: Clarification re Timeouts and Session State in the Logs

2018-08-24 Thread Daniel Schneller
Hi! Thanks for that input. I would like to understand what's going before making changes. :) Cheers, Daniel > On 24. Aug 2018, at 00:56, Igor Cicimov > wrote: > > Hi Daniel, > > We had similar issue in 2015, and the answer was: server timeout was too > short. Simple. > > On Thu, 23 Aug

Timeouts on 1.8.13

2018-08-24 Thread Kilian Ries
Hi, we are seeing timeouts with haproxy 1.8.13 running in http loadbalancing mode. We are running under high load / traffic and about 10-20k active frontend sessions. With haproxy 1.8.12 we cant reproduce the timeouts and it seems to be fine. Timeouts occure if we are running in threaded

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-24 Thread Willy Tarreau
On Fri, Aug 24, 2018 at 04:25:02PM +0200, Frederic Lecaille wrote: > Here is a reg testing file for this bug. Thanks, applied. Willy

Re: [PATCH] BUG/MINOR: lua: Bad HTTP client request duration.

2018-08-24 Thread Willy Tarreau
On Fri, Aug 24, 2018 at 08:42:20AM +0200, Frederic Lecaille wrote: > Here is a patch to fix the issue reported by Patrick in this thread (BUG: Tw > is negative with lua sleep > https://www.mail-archive.com/haproxy@formilux.org/msg30474.html). (...) Applied, thank you Fred. Willy

Re: [PATCH] DOC: typo fix in the configuration manual.

2018-08-24 Thread Arnaud Brousseau
Bump :) I'm still seeing this typo in the development branch's configuration manual [0]. The original patch [1] should still apply, let me know if you need anything else. Cheers, Arnaud. [0]: https://github.com/haproxy/haproxy/blob/master/doc/configuration.txt#L16133 [1]:

Re: HTTP/2 issues and segfaults with current 1.9-dev [7ee465]

2018-08-24 Thread Frederic Lecaille
On 08/22/2018 04:32 AM, Willy Tarreau wrote: On Wed, Aug 22, 2018 at 12:46:47AM +0200, Cyril Bonté wrote: Le 22/08/2018 à 00:40, Cyril Bonté a écrit : Hi again Willy, Le 21/08/2018 à 22:55, Cyril Bonté a écrit : Thanks for the diag. I don't remember changing anything around the proxy

Re: [PATCH] BUG/MINOR: lua: Bad HTTP client request duration.

2018-08-24 Thread Tim Düsterhus
Willy, Am 24.08.2018 um 14:53 schrieb Willy Tarreau: > Applied, thank you Fred. > While you updated the commit reference in the commit message of the reg-test patch you forgot to do so in the reg-test itself. It still refers to 7b6cc52784526c32efda44b873a4258d3ae0b8c7 (which does not exist,

Re: [PATCH] BUG/MINOR: lua: Bad HTTP client request duration.

2018-08-24 Thread Willy Tarreau
On Fri, Aug 24, 2018 at 05:58:22PM +0200, Tim Düsterhus wrote: > Willy, > > Am 24.08.2018 um 14:53 schrieb Willy Tarreau: > > Applied, thank you Fred. > > > > While you updated the commit reference in the commit message of the > reg-test patch you forgot to do so in the reg-test itself. It

Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-24 Thread Tim Düsterhus
Willy, Am 24.08.2018 um 04:19 schrieb Willy Tarreau: > Oh with H2 it's even simpler, streams are distinct from each other > so we don't reuse them and the issue doesn't exist :-) > > Does this mean I should take Patrick's patch ? > If you do so: Don't forget to squash in my reg-test (with the

Re: Issue with TCP splicing

2018-08-24 Thread haproxy
private keys private key defiantly need revoked i attached key to show how easy it is to xtract from coredump you can download certificate https://crt.sh/?d=511527676 and verify signature of message.txt using openssl smime -verify -in message.txt.p7s -content message.txt -inform PEM

Re: [PATCH] MEDIUM: lua: Add stick table support for Lua

2018-08-24 Thread Adis Nezirovic
Thierry, Something for Monday :-) Latest version of the patch in attachment: - Filter table format is flattened/simplified - I've tried to address filter table format error messages (what is the error, and which filter entry is wrong) - Fixed one bug: stktable_get_data_type() return value can

Re: [PATCH 1/2] MINOR: add be_conn_free sample fetch

2018-08-24 Thread Patrick Hemmer
On 2018/8/22 04:04, Willy Tarreau wrote: > Hi Patrick, > > On Thu, Aug 09, 2018 at 06:46:28PM -0400, Patrick Hemmer wrote: >> This adds the sample fetch 'be_conn_free([])'. This sample fetch >> provides the total number of unused connections across available servers >> in the specified backend.

Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-24 Thread Thierry Fournier
> On 24 Aug 2018, at 04:19, Willy Tarreau wrote: > > Hi Thierry, > > On Thu, Aug 23, 2018 at 09:37:43AM +0200, Thierry Fournier wrote: >> Hi, >> >> Your patch make sense, that's the right appoach, but I have a doubt about >> the place to use for doing the reinitialization. >> >> I add

Re: [PATCH 1/2] MINOR: add be_conn_free sample fetch

2018-08-24 Thread Willy Tarreau
On Fri, Aug 24, 2018 at 06:18:23PM -0400, Patrick Hemmer wrote: > > I disagree with making a special case above for maxconn 0. In fact for me > > it just means that such a server cannot accept connections, so it simply > > doesn't count in the sum, just as if it were not present. > On a server,

Re: [PATCH] MEDIUM: reset lua transaction between http requests

2018-08-24 Thread Willy Tarreau
On Fri, Aug 24, 2018 at 11:19:26PM +0200, Thierry Fournier wrote: > Technically, the patch works, but the reset of the Lua session was done > in the stream. This reset is done in the proto_http.c, so I'm not sure > that's the correct place for this reset. > > If the proto_http is the only one