Re: [PATCH] MEDIUM: global: add a 'hard-stop-after' option to cap the soft-stop time

2017-03-23 Thread Cyril Bonté
Hi Willy, Le 23/03/2017 à 07:42, Willy Tarreau a écrit : Hi Cyril, I have a few comments below : diff --git a/src/cfgparse.c b/src/cfgparse.c index 2eb25edb..9681e06b 100644 --- a/src/cfgparse.c +++ b/src/cfgparse.c @@ -1011,6 +1011,23 @@ int cfg_parse_global(const char *file, int linenum,

Re: [PATCH] MEDIUM: global: add a 'hard-stop-after' option to cap the soft-stop time

2017-03-23 Thread Willy Tarreau
On Thu, Mar 23, 2017 at 09:43:44PM +0100, Cyril Bonté wrote: > Le 23/03/2017 à 21:40, Willy Tarreau a écrit : > > On Thu, Mar 23, 2017 at 09:35:28PM +0100, Cyril Bonté wrote: > > I didn't think about the per-proxy approach but I think that emitting a > > log only for those having got killed

Re: [PATCH] MEDIUM: global: add a 'hard-stop-after' option to cap the soft-stop time

2017-03-23 Thread Cyril Bonté
Le 23/03/2017 à 21:40, Willy Tarreau a écrit : On Thu, Mar 23, 2017 at 09:35:28PM +0100, Cyril Bonté wrote: I didn't think about the per-proxy approach but I think that emitting a log only for those having got killed connections would be nice given that most of the time there will be very few

Re: [PATCH] MEDIUM: global: add a 'hard-stop-after' option to cap the soft-stop time

2017-03-23 Thread Willy Tarreau
On Thu, Mar 23, 2017 at 09:35:28PM +0100, Cyril Bonté wrote: > Hi Olivier and Willy, > > Le 23/03/2017 à 14:50, Willy Tarreau a écrit : > > Hi Olivier, > > > > On Thu, Mar 23, 2017 at 02:17:38PM +0100, Olivier Doucet wrote: > > > I was also thinking about dumping how many connections were

Re: [PATCH] MEDIUM: global: add a 'hard-stop-after' option to cap the soft-stop time

2017-03-23 Thread Willy Tarreau
On Thu, Mar 23, 2017 at 10:44:13PM +0100, Cyril Bonté wrote: > When SIGUSR1 is received, haproxy enters in soft-stop and quits when no > connection remains. > It can happen that the instance remains alive for a long time, depending > on timeouts and traffic. This option ensures that soft-stop

Re: Send PROXY protocol header from HAProxy

2017-03-23 Thread Dave J
Thanks very much Aaron, that did the trick :) My config file now has the updated line server TestServer01 10.6.186.24:48080 send-proxy From: Aaron West Sent: 23 March 2017 17:59

[PATCH] improve DNS response parsing

2017-03-23 Thread Baptiste
Hi all, Currently, HAProxy picks up the first IP available in the response which matches a familiy preference or a subnet preference. That said, there are chances that this IP is already assigned to an other server in the backend while some other IPs are unassigned in the same response. This

Re: [PATCH] MEDIUM: global: add a 'hard-stop-after' option to cap the soft-stop time

2017-03-23 Thread Cyril Bonté
Hi Olivier and Willy, Le 23/03/2017 à 14:50, Willy Tarreau a écrit : Hi Olivier, On Thu, Mar 23, 2017 at 02:17:38PM +0100, Olivier Doucet wrote: I was also thinking about dumping how many connections were force-killed in log, if it's easy. I thought about it as well while responding but

[PATCH] MEDIUM: global: add a 'hard-stop-after' option to cap the soft-stop time

2017-03-23 Thread Cyril Bonté
When SIGUSR1 is received, haproxy enters in soft-stop and quits when no connection remains. It can happen that the instance remains alive for a long time, depending on timeouts and traffic. This option ensures that soft-stop won't run for too long. Example: global hard-stop-after 30s #

Adding custom TLV to proxy protocol sent to backend servers?

2017-03-23 Thread Christian Rohmann
Hello! Is there a way to make use of the extensibility of the PROXY protocol version 2 and to add a TLV-field which is then sent to the backend servers? I would like to i.e. generate a random id value per request, add that to the access log and also forward this very value to the backend

Re: All "server" settings supported on "default-server" lines

2017-03-23 Thread Emmanuel Hocdet
> Le 22 mars 2017 à 22:58, Willy Tarreau a écrit : > > On Wed, Mar 22, 2017 at 05:30:09PM +0100, Emmanuel Hocdet wrote: >> I have patches sent in the ML who change the internal implementation of >> no/force-tlsxx and add min/max-tlsxx (who can replace no/force usage). >> It could

Re: All "server" settings supported on "default-server" lines

2017-03-23 Thread Frederic Lecaille
On 03/21/2017 07:54 PM, Frederic Lecaille wrote: Hello HAProxy ML, I am starting this new thread to publish a serie of patches to make all "server" settings be supported on "default-server" lines. This is a preliminary work for "server templates" feature. New boolean settings have been added

Re: All "server" settings supported on "default-server" lines

2017-03-23 Thread Willy Tarreau
On Thu, Mar 23, 2017 at 11:26:50AM +0100, Emmanuel Hocdet wrote: > Emeric's suggestion is not on the ML. I transcripted it in the other e-mail of this same thread. > If no- and force- are defined as deprecated it can make a difference. > I'm not used to seeing this kind of proposal for haproxy

Re: All "server" settings supported on "default-server" lines

2017-03-23 Thread Frederic Lecaille
On 03/23/2017 12:03 PM, Frederic Lecaille wrote: On 03/21/2017 07:54 PM, Frederic Lecaille wrote: [snipped] At this time, as "id" remains as unique setting supported by "server", the patch attached to this mail now produces these error messages: [ALERT] 081/111458 (12190) : parsing

Individual or even dynamic tcp-check send (binary) commands per backend server? rand()? unique-id()?

2017-03-23 Thread Christian Rohmann
Hello HAProxy community! I configured a protocol specific tcp-check using send-binary and expect binary. Just like described on https://blog.danman.eu/mongodb-haproxy/ for MongoDB. What a cool feature! The check itself works just fine. But, to make it perfect I need to send an individual

Re: Send PROXY protocol header from HAProxy

2017-03-23 Thread Aaron West
Hi Dave, I don't see the "send-proxy" directive in your config, have you tried it : https://cbonte.github.io/haproxy-dconv/1.8/configuration.html#5.2-send-proxy Sorry if I'm misunderstanding something already... Aaron West Loadbalancer.org Limited +44 (0)330 380 1064 www.loadbalancer.org On

Re: [PATCH] MEDIUM: global: add a 'hard-stop-after' option to cap the soft-stop time

2017-03-23 Thread Olivier Doucet
Hello there, 2017-03-23 7:42 GMT+01:00 Willy Tarreau : > Additionally, since it helps improving the reliability of the service > during reloads without adding particular features and the patch is > reasonably small and isolated, I was thinking we could backport it to > 1.7 and even

Send PROXY protocol header from HAProxy

2017-03-23 Thread Dave J
I've probably got lost in the masses of documentation on this subject, but I'm trying to configure my HAProxy process to send the PROXY protocol header as described at http://www.haproxy.org/download/1.8/doc/proxy-protocol.txt. This is because I am having to write support for the PROXY protocol

Re: All "server" settings supported on "default-server" lines

2017-03-23 Thread Emmanuel Hocdet
> Le 23 mars 2017 à 12:25, Willy Tarreau a écrit : > > On Thu, Mar 23, 2017 at 11:26:50AM +0100, Emmanuel Hocdet wrote: >> Emeric's suggestion is not on the ML. > > I transcripted it in the other e-mail of this same thread. > >> If no- and force- are defined as deprecated it can

Re: [PATCH] MEDIUM: global: add a 'hard-stop-after' option to cap the soft-stop time

2017-03-23 Thread Willy Tarreau
Hi Olivier, On Thu, Mar 23, 2017 at 02:17:38PM +0100, Olivier Doucet wrote: > Hello there, > > 2017-03-23 7:42 GMT+01:00 Willy Tarreau : > > > Additionally, since it helps improving the reliability of the service > > > during reloads without adding particular features and the patch

Re: [Patches] TLS methods configuration reworked

2017-03-23 Thread Emeric Brun
Hi Manu, On 03/22/2017 06:24 PM, Emmanuel Hocdet wrote: > >> Le 22 mars 2017 à 16:30, Emmanuel Hocdet a écrit : >> […] >> 0005 force-tlsxx implementation compatibility (Emeric first point) >> >> For the second point >>> But we will face issue using 'force-' when openssl will

Re: Propagating agent-check weight change to tracking servers

2017-03-23 Thread Willy Tarreau
Hi Michal, On Wed, Mar 15, 2017 at 10:13:01PM +0100, Michal wrote: > Hello! > Any news in this topic? Is there anything wrong with my patch? So I checked it but it still has the problem of propagating absolute weights, which, as I explained earlier, will break lots of setups. I tend to think

Re: [PATCH] MEDIUM: global: add a 'hard-stop-after' option to cap the soft-stop time

2017-03-23 Thread Willy Tarreau
Hi Cyril, I have a few comments below : > diff --git a/src/cfgparse.c b/src/cfgparse.c > index 2eb25edb..9681e06b 100644 > --- a/src/cfgparse.c > +++ b/src/cfgparse.c > @@ -1011,6 +1011,23 @@ int cfg_parse_global(const char *file, int linenum, > char **args, int kwm) > } > }