Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-11 Thread Aleksandar Lazic
Hi. Am 10-08-2018 17:12, schrieb Willy Tarreau: On Fri, Aug 10, 2018 at 09:54:38AM -0400, Patrick Hemmer wrote: Merge it! Now done! Quite happy to see this done with. Any issues can be addressed as bug fixes. Yes, same here. I've updated the ROADMAP file to remove this 8-years old entry :

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-11 Thread Willy Tarreau
Hi Aleks, On Sat, Aug 11, 2018 at 10:27:42AM +0200, Aleksandar Lazic wrote: > I think it is a requeue mechanism for the connection and not a selector for > a server or a backend, but I can be wrong. That's it. I'll try to explain shortly. You're probably aware how the queuing mechanism works in h

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-11 Thread Aleksandar Lazic
Hi Willy. On 11/08/2018 11:04, Willy Tarreau wrote: Hi Aleks, On Sat, Aug 11, 2018 at 10:27:42AM +0200, Aleksandar Lazic wrote: I think it is a requeue mechanism for the connection and not a selector for a server or a backend, but I can be wrong. That's it. I'll try to explain shortly. You'

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-11 Thread Patrick Hemmer
On 2018/8/11 11:25, Aleksandar Lazic wrote: > Hi Willy. > > > On 11/08/2018 11:04, Willy Tarreau wrote: >> Hi Aleks, >> >> On Sat, Aug 11, 2018 at 10:27:42AM +0200, Aleksandar Lazic wrote: >>> I think it is a requeue mechanism for the connection and not a >>> selector for >>> a server or a backen

Re: [PATCH 1/2] MEDIUM: add set-priority-class and set-priority-offset

2018-08-11 Thread Willy Tarreau
On Sat, Aug 11, 2018 at 02:48:27PM -0400, Patrick Hemmer wrote: > Actually it does take a sample expression, not a constant. This was done > so that you could calculate a priority based on multiple criteria in the > request. Oh that's perfect then, I didn't even notice when reviewing the patches.

race condition causing some corruption in lua socket service response

2018-08-11 Thread Sachin Shetty
Hi, We are using a http-req lua action to dynamically set some app specific metadata headers. The lua handler connects to a upstream memcache like service over tcp to fetch additional metadata. Here is a simplified config: function get_from_gds(txn) local key = txn.sf:req_fhdr("host") l

Re: lua socket settimeout has no effect

2018-08-11 Thread Sachin Shetty
Hi Cyril, Any idea how I can deterministically set the readtimeout as well? Thanks Sachin On Fri, Jul 27, 2018 at 1:23 PM, Sachin Shetty wrote: > Thankyou Cyril, your patch fixed the connect issue. > > Read timeout still seems a bit weird though, at settimeout(1), readtimeout > kicks in at abo