we were decoding all substring and then parsing; this could lead to
consider & and = in decoding result as delimiters where it should not.
this patch reverses the order by first parsing and then decoding each key
and value separately.
This patch should be backported to 2.0
Signed-off-by: William
we were checking two times old_ckchs where we wanted to check whether
the transaction path was freed (and so null) before
this should fix issue #351
Reported-by: Илья Шипицин
Signed-off-by: William Dauchy
---
src/ssl_sock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
gcc complains rightfully:
src/ssl_sock.c: In function ‘ssl_sock_prepare_all_ctx’:
src/ssl_sock.c:5507:3: warning: format not a string literal and no format
arguments [-Wformat-security]
ha_warning(errmsg);
^
src/ssl_sock.c:5509:3: warning: format not a string literal and no format
On Sat, Nov 23, 2019 at 09:14:33PM +0100, William Dauchy wrote:
> recent commit 8b453912ce9a ("MINOR: ssl: ssl_sock_prepare_ctx() return an
> error code")
> converted all errors handling; in this patch we always test `err`, but
> three of them are missing. I did not found a plausible explanation
This commit removes the explicit checks for `if (err)` before
passing `err` to `memprintf`. `memprintf` already checks itself
whether the `**out*` parameter is `NULL` before doing anything.
This reduces the indentation depth and makes the code more readable,
before there is less boilerplate code.
On Sat, Nov 23, 2019 at 10:44:31PM +0100, William Dauchy wrote:
> we were checking two times old_ckchs where we wanted to check whether
> the transaction path was freed (and so null) before
>
> this should fix issue #351
>
> Reported-by: Илья Шипицин
> Signed-off-by: William Dauchy
> ---
>
recent commit 8b453912ce9a ("MINOR: ssl: ssl_sock_prepare_ctx() return an error
code")
converted all errors handling; in this patch we always test `err`, but
three of them are missing. I did not found a plausible explanation about
it.
this should fix issue #374
Fixes: 8b453912ce9a ("MINOR: ssl:
Hi,
This is a friendly bot that watches fixes pending for the next haproxy-stable
release! One such e-mail is sent periodically once patches are waiting in the
last maintenance branch, and an ideal release date is computed based on the
severity of these fixes and their merge date. Responses
Hi,
This is a friendly bot that watches fixes pending for the next haproxy-stable
release! One such e-mail is sent periodically once patches are waiting in the
last maintenance branch, and an ideal release date is computed based on the
severity of these fixes and their merge date. Responses
9 matches
Mail list logo
