Re: [PATCH 3/3] MINOR: stream: Use stream_generate_unique_id

On Thu, Feb 27, 2020 at 12:50:44PM +0100, Tim Düsterhus wrote: > >>/* add unique-id if "header-unique-id" is specified */ > >> + if (sess->fe->header_unique_id && > >> !LIST_ISEMPTY(>fe->format_unique_id)) { > > ^^ > > All the unique-id generation seems to

Re: [PATCH 3/3] MINOR: stream: Use stream_generate_unique_id

Willy, Am 27.02.20 um 03:43 schrieb Willy Tarreau: > On Wed, Feb 26, 2020 at 04:20:51PM +0100, Tim Duesterhus wrote: >> This patch replaces the ad-hoc generation of stream's `unique_id` values >> by calls to `stream_generate_unique_id`. > > It seems to me that it won't generate the unique_id

Re: Log lines in 2.0

Hi Tim, On Thu, Feb 27, 2020, 10:09 PM Tim Düsterhus wrote: > Igor, > > Am 27.02.20 um 05:27 schrieb Igor Cicimov: > > Feb 27 03:37:21 ip-10-0-4-33 haproxy[21361]: > > 0d56:monitor-in.accept(0009)=0012 from [IP:56142] ALPN= > > Feb 27 03:37:21 ip-10-0-4-33 haproxy[21361]: > >

Re: Log lines in 2.0

Igor, Am 27.02.20 um 05:27 schrieb Igor Cicimov: > Feb 27 03:37:21 ip-10-0-4-33 haproxy[21361]: > 0d56:monitor-in.accept(0009)=0012 from [IP:56142] ALPN= > Feb 27 03:37:21 ip-10-0-4-33 haproxy[21361]: > 0d56:monitor-in.clireq[0012:]: GET /monitor-url HTTP/1.1 > Feb 27 03:37:21

[PATCH v2 2/2] MINOR: stream: Use stream_generate_unique_id

This patch replaces the ad-hoc generation of stream's `unique_id` values by calls to `stream_generate_unique_id`. --- src/http_ana.c | 14 ++ src/http_fetch.c | 17 - src/log.c| 3 +-- 3 files changed, 15 insertions(+), 19 deletions(-) diff --git

Prometheus service

Hi all. I have upgraded to HAProxy 2.0.13 and enabled Prometheus service on it. In previous version (1.8.8) I used haproxy_exporter and I have haproxy_server_check_duration_milliseconds and new_session_rate for each server but in HAProxy v2.0.13

[PATCH v2 1/2] MINOR: stream: Add stream_generate_unique_id function

Currently unique IDs for a stream are generated using repetitive code in multiple locations, possibly allowing for inconsistent behavior. --- include/proto/stream.h | 3 +++ src/http_ana.c | 1 - src/stream.c | 24 3 files changed, 27 insertions(+), 1

Re: [PATCH 2/3] MINOR: stream: Add stream_generate_unique_id function

Willy, Am 27.02.20 um 03:49 schrieb Willy Tarreau: >> +int stream_generate_unique_id(struct stream *strm, struct list *format) { > > Please put the function's opening brace on its own line. The reason for > this is when you have many arguments and variables, it easily becomes a > mess where you

Re: Log lines in 2.0

Hi Willy, On Fri, Feb 28, 2020, 2:15 AM Willy Tarreau wrote: > Hi Igor, > > On Thu, Feb 27, 2020 at 10:36:44PM +1100, Igor Cicimov wrote: > > > This looks like you are running HAProxy in debug mode. Debug mode is > > > enabled via the '-d' command line switch or 'debug' configuration > option >

Re: Log lines in 2.0

On Fri, Feb 28, 2020 at 01:49:36PM +1100, Igor Cicimov wrote: > > Do you have a *real* use case of "debug" in the global section that is > > not easily solved with "-d" ? I'm asking because I'd really like to see > > this design mistake disappear, but am not (too much) stubborn. > > Not a problem

using variables in reg-tests

Hello, ${no-htx} option http-use-htx how can setup that variable per test run? I want to run reg-tests with and without htx cheers, Ilya Shipitcin

RE: HAProxy v2.1.0 health checks with POST and data corrupted by extra "connection: close"

Hello Willy, As per my findings, the existing "httpchk" directive contains header and body as single argument args[4] and there is no definite identifier to differentiate header from body. Therefore, i have added 2 new options to http-check directive for header and body. Specifying these

Re: FW: HAProxy: Information request

Hi, please be aware you are posting to a public mailinglist. You might want to check where you sent your emails. Regards, Sander Klein On 2020-02-27 22:14, EMEA Request wrote: Hi Team, Apologies for delayed response. Can you please help with the details provided below and provide a

SRV Record Priority Values

Hello List, We use SRV records extensively (for internal service discovery, etc.). When the patch was integrated to support a 0 weighted SRV records, I thought that would simplify our setup, because at the time, I thought 0 weight meant "backup server" without a "backup" flag on the server.

Re: [PATCH] OPTIM: startup: fast unique_id allocation for acl

On Tue, 2020-02-25 at 11:47 +0100, Willy Tarreau wrote: [...] > > The patch was written under the assumption that you wanted exactly > > the same behavior. > > Yes that's preferable indeed. > > > Since you say we maybe can drop them, I have created a > > new patch which should work fine but does

Re: [PATCH] OPTIM: startup: fast unique_id allocation for acl

On Thu, Feb 27, 2020 at 02:35:38PM +, Carl Henrik Holth Lunde wrote: > > Well, after having looked at it more closely, I'd still rather keep > > the hole-filling algorithm, so if you have a v3 between the two > > versions it would be great :-) > > Do you mean just with an exit code? I

[PATCH] BUG/MINOR: dns: ignore trailing dot

As per issue #435 a hostname with a trailing dot confuses our DNS code, as for a zero length DNS label we emit a null-byte. This change makes us ignore the zero length label instead. Must be backported to 1.8. --- As discussed in issue #435 --- src/dns.c | 6 ++ 1 file changed, 6

Re: [PATCH 3/3] MINOR: stream: Use stream_generate_unique_id

Willy, Am 27.02.20 um 13:32 schrieb Willy Tarreau: > On Thu, Feb 27, 2020 at 12:50:44PM +0100, Tim Düsterhus wrote: /* add unique-id if "header-unique-id" is specified */ + if (sess->fe->header_unique_id && !LIST_ISEMPTY(>fe->format_unique_id)) { >>>

Re: [PATCH 3/3] MINOR: stream: Use stream_generate_unique_id

On Thu, Feb 27, 2020 at 02:17:04PM +0100, Tim Düsterhus wrote: > > Does this mean that the unique-id will now be generated only when > > logging ? Because if that's the case it won't find any element from > > the request anymore. > > If neither the unique-id-header is set, nor the unique-id

Re: We'd Like to Offer You a Free Infographic!

Hi there, Just following up on our last email on your article on RFID referring to

Re: SRV Record Priority Values

Hi Luke, On Thu, Feb 27, 2020 at 03:07:35PM +0100, Luke Seelenbinder wrote: > Hello List, > > We use SRV records extensively (for internal service discovery, etc.). > > When the patch was integrated to support a 0 weighted SRV records, I thought > that would simplify our setup, because at the

Re: [PATCH] supress cirrus-ci OS version check

On Wed, Feb 26, 2020 at 07:32:44PM +0500, ??? wrote: > I've adjusted commit message. Now merged, thanks guys! Willy

Re: Log lines in 2.0

Hi Igor, On Thu, Feb 27, 2020 at 10:36:44PM +1100, Igor Cicimov wrote: > > This looks like you are running HAProxy in debug mode. Debug mode is > > enabled via the '-d' command line switch or 'debug' configuration option > > (http://cbonte.github.io/haproxy-dconv/2.1/configuration.html#debug). >

Re: Prometheus service

Le 27/02/2020 à 11:36, Seena Fallah a écrit : Hi all. I have upgraded to HAProxy 2.0.13 and enabled Prometheus service on it. In previous version (1.8.8) I used haproxy_exporter  and I have haproxy_server_check_duration_milliseconds and

[PR] MINOR: Add health check duration metric to Prometheus service

Dear list! Author: Seena Fallah Number of patches: 1 This is an automated relay of the Github pull request: MINOR: Add health check duration metric to Prometheus service Patch title(s): MINOR: Add health check duration metric to Prometheus service Link:

Re: [PATCH] OPTIM: startup: fast unique_id allocation for acl

On Thu, 2020-02-27 at 15:48 +0100, Willy Tarreau wrote: > On Thu, Feb 27, 2020 at 02:35:38PM +, Carl Henrik Holth Lunde > wrote: > > > Well, after having looked at it more closely, I'd still rather > > > keep > > > the hole-filling algorithm, so if you have a v3 between the two > > > versions

Re: SRV Record Priority Values

Hi Willy, > Yes it is! They're typically used to drain old user sessions while > progressively taking a server off. Some also use them to let an > overloaded server cool down for a moment with no extra session. This > is completely unrelated to backup servers in fact, which have their > own

FW: HAProxy: Information request

Hi Team, Apologies for delayed response. Can you please help with the details provided below and provide a quote. Thanks and Regards, [cid:image002.jpg@01D5ED7C.621F1730] Anandita Sharma | Procurement Specialist –GSDC| SoftwareONE

Linkedin Admire

I saw your profile on LinkedIn, I'm sorry to intrude but I couldn't help but notice your lovely smile so I thought to write you,if there is any possibility of knowing each other better