Re: [PATCH] switch to clang-9 in Linux/travis-ci builds

2020-03-14 Thread Willy Tarreau
Hi Ilya, On Fri, Jan 24, 2020 at 11:46:45AM +0500, ??? wrote: > Hello, > > let us use clang-9 instead of default clang-7 for linux builds. It seems I missed this one. Now applied carefully, we'll see. If it causes new failures, we'll adjust accordingly. Willy

Re: Peers Protocol "Table Type"

2020-03-14 Thread Willy Tarreau
On Sat, Mar 14, 2020 at 12:07:39PM +0100, Tim Düsterhus wrote: > Willy, > > Am 14.03.20 um 10:13 schrieb Willy Tarreau: > >> This is about the "Table Definition Message", more specifically the > >> "Encoded Table Type". > >> > >> docs/peers-v2.0.txt says: > > > > There's also doc/peers.txt which

[PATCH] CLEANUP: connection: Stop directly setting an ist's .ptr

2020-03-14 Thread Tim Duesterhus
Instead replace the complete `ist` by the value returned from `ist2`. This was noticed during review of issue #549. --- src/connection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/connection.c b/src/connection.c index c1ec2664e..462dbf029 100644 ---

[PR] DOC: correct typo in alert message

2020-03-14 Thread PR Bot
Dear list! Author: Balvinder Singh Rawat Number of patches: 1 This is an automated relay of the Github pull request: DOC: correct typo in alert message Patch title(s): correct typo in alert message Link: https://github.com/haproxy/haproxy/pull/547 Edit locally: wget

Re: Sudden queueing to backends

2020-03-14 Thread Willy Tarreau
Hi Sander, On Tue, Mar 10, 2020 at 10:28:38AM +0100, Sander Klein wrote: > Hi All, > > I'm looking in a strange issue I'm having and I start to think it is HAProxy > related. > > I have a setup with HAProxy serving multiple frontends and multiple backends > which are Nginx server with PHP-FPM.

Re: [PATCH[ special purpose weekly CI (spellcheck)

2020-03-14 Thread Willy Tarreau
On Sat, Mar 14, 2020 at 08:40:31AM +0500, ??? wrote: > > Ilya, just a question, what will be the impact of this ? Will we > > all be spammed or anything or are you the one volunteering to stand > > in front of the cannon ? :-) > > > > > yes, I will take care of it. Thanks, now applied,

Re: [PATCH] BUILD: Avoid warning about ignoring write()'s return value in BUG_ON()

2020-03-14 Thread Tim Düsterhus
Willy, Am 14.03.20 um 11:14 schrieb Willy Tarreau: > Now done. I've also cleaned up the null-derefw warning in the debugging > code of the pools. > Can't the pools simply use `ABORT_NOW()` instead of `*DISGUISE((volatile int *)0) = 0;`? Best regards Tim Düsterhus

Re: Peers Protocol "Table Type"

2020-03-14 Thread Tim Düsterhus
Willy, Am 14.03.20 um 12:13 schrieb Willy Tarreau: > Yes, feel free to do so, this will definitely help get it eventually done. Here it is: https://github.com/haproxy/haproxy/issues/548 I labeled it "bug", because it can be considered a bug that the on-the-wire format relies on some internal

[PATCH] fourth round of typo fixes

2020-03-14 Thread Илья Шипицин
Hello, more documentation fixes. Ilya Shipitcin From de4a671e8530b36fea78749455c1dd868c986522 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 14 Mar 2020 17:47:28 +0500 Subject: [PATCH] DOC: assorted typo fixes in the documentation This is the fourth round of cleanups in various docs

Re: [PATCH] BUILD: Avoid warning about ignoring write()'s return value in BUG_ON()

2020-03-14 Thread Willy Tarreau
On Fri, Mar 13, 2020 at 07:07:54PM +0100, Willy Tarreau wrote: > On Fri, Mar 13, 2020 at 05:41:14PM +0100, Tim Düsterhus wrote: > > Willy, > > > > Am 13.03.20 um 17:34 schrieb Willy Tarreau: > > > Indeed, just found it in my queue. However we usually use it > > > differently, with the function

Re: Peers Protocol "Table Type"

2020-03-14 Thread Tim Düsterhus
Willy, Am 14.03.20 um 10:13 schrieb Willy Tarreau: >> This is about the "Table Definition Message", more specifically the >> "Encoded Table Type". >> >> docs/peers-v2.0.txt says: > > There's also doc/peers.txt which is more recent and more complete. I don't > know if there are still some parts

Re: [PATCH] BUILD: Avoid warning about ignoring write()'s return value in BUG_ON()

2020-03-14 Thread Tim Düsterhus
Willy, Am 14.03.20 um 12:15 schrieb Willy Tarreau: > Good point we could indeed. Quite frankly it's a detail since this > really is developer-only code. Nobody wants to run with DEBUG_UAF by > accident, it's slow and uses a lot of memory :-) > As I had the code open anyway to make that CLEANUP