Re: Broken SNI with crt-list for HAProxy 2.1.x after upgrade from Stretch to Buster

2020-06-15 Thread William Lallemand
On Sat, Jun 13, 2020 at 04:55:53PM +0200, Tim Düsterhus wrote: > William, > > Am 13.06.20 um 16:46 schrieb Tim Düsterhus: > > tune.ssl.default-dh-param 2048 solved the issue for me. > > > > I'd argue that this is a bug in HAProxy nonetheless, because apparently > > the crt-list file is not fully

Invitation to FDC October 2020 Training's

2020-06-15 Thread Foscore Development Center

Re: Broken SNI with crt-list for HAProxy 2.1.x after upgrade from Stretch to Buster

2020-06-15 Thread Tim Düsterhus
William, Am 15.06.20 um 14:56 schrieb William Lallemand: > I think I found the problem, could you try the attached patch for 2.1? > I'd prefer not, because I don't have a staging system where I could easily reproduce the issue (and generating SSL certs to test this properly is annoying). I was e

Re: Broken SNI with crt-list for HAProxy 2.1.x after upgrade from Stretch to Buster

2020-06-15 Thread William Lallemand
On Mon, Jun 15, 2020 at 03:48:40PM +0200, Tim Düsterhus wrote: > William, > > Am 15.06.20 um 14:56 schrieb William Lallemand: > > I think I found the problem, could you try the attached patch for 2.1? > > > > I'd prefer not, because I don't have a staging system where I could > easily reproduce

[PATCH] BUG/MINOR: systemd: Wait for network to be online

2020-06-15 Thread Ryan O'Hara
Change systemd service file to wait for network to be completely online. This solves two problems: If haproxy is configured to bind to IP address(es) that are not yet assigned, haproxy would previously fail. The workaround is to use "option transparent". If haproxy us configured to use a resolver

Re: [PATCH] BUG/MAJOR: Fix bogus free() during deinit() for http-request rules

2020-06-15 Thread Willy Tarreau
On Sun, Jun 14, 2020 at 05:27:36PM +0200, Tim Duesterhus wrote: > We cannot simply `release_sample_expr(rule->arg.vars.expr)` for a > `struct act_rule`, because `rule->arg` is a union that might not > contain valid `vars`. This leads to a crash on a configuration using > `http-request redirect` and

Re: VTest does not test deinit

2020-06-15 Thread Willy Tarreau
Hi Tim, On Sun, Jun 14, 2020 at 06:24:19PM +0200, Tim Düsterhus wrote: > Hi List, > Willy, > Ilya, > > I noticed that the reg-tests were unable find the issue reported by > William here: > https://www.mail-archive.com/haproxy@formilux.org/msg37637.html > > This is because VTest never performs a

Re: [PATCH] BUG/MINOR: systemd: Wait for network to be online

2020-06-15 Thread Ryan O'Hara
I posted this patch to start some discussion here. I'm not the first to notice this problem but I was, until now, hesitant to change the systemd service file until now. The reason for this was that waiting for network-online.target could delay boot time. Please see systemd network target docs here

[PATCH 2/4] BUG/MINOR: sample: Fix freeing of conv_exprs in release_sample_expr

2020-06-15 Thread Tim Duesterhus
Instead of just calling release_sample_arg(conv_expr->arg_p) we also must free() the conv_expr itself (after removing it from the list). Given the following example configuration: frontend foo bind *:8080 mode http http-request set-var(txn.foo) str(bar) acl is_

[PATCH 0/4] Fix more frees

2020-06-15 Thread Tim Duesterhus
Willy, this series fixes up a few more frees. This time I have verified the changes a bit more carefully, running configuration check on a real world configuration of mine within valgrind. It still reports a five leaks (but less than without applying these patches!) and does not report any memory

[PATCH 3/4] BUG/MINOR: haproxy: Free proxy->format_unique_id during deinit

2020-06-15 Thread Tim Duesterhus
Given the following example configuration: frontend foo mode http bind *:8080 unique-id-format x Running a configuration check with valgrind reports: ==30712== 42 (40 direct, 2 indirect) bytes in 1 blocks are definitely lost in loss record 18 of 39 ==30712==

[PATCH 4/4] BUG/MINOR: haproxy: Add missing free of server->(hostname|resolvers_id)

2020-06-15 Thread Tim Duesterhus
Given the following example configuration: resolvers test nameserver test 127.0.0.1:53 listen foo bind *:8080 server foo example.com resolvers test Running a configuration check within valgrind reports: ==21995== 5 bytes in 1 blocks are definitely lost in loss

[PATCH 1/4] BUG/MINOR: acl: Fix freeing of expr->smp in prune_acl_expr

2020-06-15 Thread Tim Duesterhus
Instead of simply calling free() in expr->smp->arg_p in certain cases properly free the sample using release_sample_expr(). Given the following example configuration: frontend foo bind *:8080 mode http http-request set-var(txn.foo) str(bar) acl is_match str(foo

Re: [PATCH 0/4] Fix more frees

2020-06-15 Thread Willy Tarreau
Hi Tim, On Tue, Jun 16, 2020 at 12:03:01AM +0200, Tim Duesterhus wrote: > Willy, > > this series fixes up a few more frees. This time I have verified the changes > a bit more carefully, running configuration check on a real world > configuration > of mine within valgrind. It still reports a five