Dear list,
Formatting on PRs is a hot topic, but IMHO it should be done by an
automated tool so we can forget about it and focus on the core of the
PR, not the style. A git pre-hook would be best.
> I'd say it is friendly mood not to push people to comply formatting (who cares
> of indentation
Well, there are formatters like clang format or similar. We can even run
them in pipeline. But it has nothing to do with compilation and we should
not fail build because of that
On Thu, Dec 17, 2020, 5:35 PM Nicolas CARPi wrote:
> Dear list,
>
> Formatting on PRs is a hot topic, but IMHO it
commit c55a626217a7e676e1cc ("MINOR: contrib/prometheus-exporter: Add
missing global and per-server metrics") is renaming two metrics:
server_idle_connections_current
server_idle_connections_limit
This patch to propose to backport this change in 2.2, 2.1. and 2.0 to
make it consitent accross
To fail or not to fail. That is the question! :)
I'd add to that the contributor documentation should be updated to add
steps for having a clang-format (or any other formatter) as a git
pre-hook.
I'm partial to failing the build (in CI) to avoid using further
electricity if the first step
Hi guys,
On Thu, Dec 17, 2020 at 05:39:45PM +0100, Tim Düsterhus wrote:
> Ilya,
>
> [Willy: Note for you below]
>
> Am 17.12.20 um 10:01 schrieb ???:
> > well, I met some projects that are insane on formatting.
> > it is funny each time, when discussing new PR "please fix your
Ilya,
[Willy: Note for you below]
Am 17.12.20 um 10:01 schrieb Илья Шипицин:
> well, I met some projects that are insane on formatting.
> it is funny each time, when discussing new PR "please fix your formatting"
> (weeks spent on that), after PR is merged something is broken because of
> lack
чт, 17 дек. 2020 г. в 21:39, Tim Düsterhus :
> Ilya,
>
> [Willy: Note for you below]
>
> Am 17.12.20 um 10:01 schrieb Илья Шипицин:
> > well, I met some projects that are insane on formatting.
> > it is funny each time, when discussing new PR "please fix your
> formatting"
> > (weeks spent on
Nicolas,
Am 17.12.20 um 15:53 schrieb Nicolas CARPi:
> To fail or not to fail. That is the question! :)
>
> I'd add to that the contributor documentation should be updated to add
> steps for having a clang-format (or any other formatter) as a git
> pre-hook.
As someone who actually contributes
Hey Tim,
Sorry I wasn't clear in my message, I should have written that the doc
needs to be updated only if you ever chose to add this formatting check.
But as you stated, it would be a lot of work and commit noise for little
benefit and I understand completely why you would not want to do that.
Dear list,
For purely illustration purposes, this is the kind of diff that would be
generated if one were to clang-format all the .c files:
https://github.com/deltablot/haproxy/commit/878ba41e4742b39034686d2b6feb3c561edeb72a
Showing 195 changed files with 177,997 additions and 174,367
Dear list!
Author: Jan Wagner
Number of patches: 1
This is an automated relay of the Github pull request:
smp_size and sample_size seems to be mixed in docu
Patch title(s):
smp_size and sample_size seems to be mixed
Link:
https://github.com/haproxy/haproxy/pull/1012
Edit locally:
Dear Tim,
> It'll probably get a quite bit smaller if you'd add a configuration file
> that configures the indentation to happen using tabs instead of spaces.
You're correct. It was just a quick and dirty try with default config to
see if things can still compile after running it, I have no
Nicolas,
Am 17.12.20 um 22:30 schrieb Nicolas CARPi:
> For purely illustration purposes, this is the kind of diff that would be
> generated if one were to clang-format all the .c files:
>
> https://github.com/deltablot/haproxy/commit/878ba41e4742b39034686d2b6feb3c561edeb72a
>
> Showing 195
well, I met some projects that are insane on formatting.
it is funny each time, when discussing new PR "please fix your formatting"
(weeks spent on that), after PR is merged something is broken because of
lack of testing.
I'd say it is friendly mood not to push people to comply formatting (who
Ilya,
Am 17.12.20 um 08:26 schrieb Илья Шипицин:
> gcc 11 (delivered with fedora rawhide) introduces indentation check.
> it is totally harmless.
>
> this patch suppresses it.
> it resolves #998
> might be backported to all supported branches.
>
Can we please fix the actual issue instead of
15 matches
Mail list logo
