Re: [PATCH v3] MINOR: converter: adding support for url_enc

2021-01-06 Thread Willy Tarreau
On Wed, Jan 06, 2021 at 11:39:50PM +0100, William Dauchy wrote: > add base support for url encode following RFC3986, supporting `query` > type only. (...) looks perfect now, thus merged :-) Thank you! Willy

Re: [PATCH v2] MINOR: converter: adding support for url_enc

2021-01-06 Thread William Dauchy
Hi Willy, Thanks for the review. On Tue, Jan 5, 2021 at 12:27 PM Willy Tarreau wrote: > > +/* Check url-encode type */ > > +enum encode_type { > > + ENC_QUERY = 0, > > +}; > > Please leave a blank line here between the end of the enum and the function. fixed in v3. I don't know why but I

[PATCH v3] MINOR: converter: adding support for url_enc

2021-01-06 Thread William Dauchy
add base support for url encode following RFC3986, supporting `query` type only. - add test checking url_enc/url_dec/url_enc - update documentation - leave the door open for future changes this should resolve github issue #941 Signed-off-by: William Dauchy --- doc/configuration.txt

[PATCH] improve SSL guarding, use macro instead of openssl version

2021-01-06 Thread Илья Шипицин
Hi, another series of removing HA_OPENSSL_VERSION Ilya From 13b0f8e575021b4d3c10fd3a2066ff83b26588bc Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 7 Jan 2021 11:55:45 +0500 Subject: [PATCH 1/3] BUILD: SSL: guard TLS13 ciphersuites with HAVE_SSL_CTX_SET_CIPHERSUITES accidently

Re: [PATCH] BUG/MINOR: Error out when a `server` has an `AF_UNSPEC` address

2021-01-06 Thread Willy Tarreau
On Tue, Jan 05, 2021 at 11:10:09PM -0700, Thayne McCombs wrote: > Here's a patch that I think should fix this: Thank you, I've tested it and it works. I've completed your commit message with the context that Tim added in his proposed patch. I've also completed your regtest to add unresolvable

Re: [PR] Fixed null pointer dereference in srv_cleanup_connections()

2021-01-06 Thread Amaury Denoyelle
PR Bot wrote: > Dear list! > Author: Peter Skarpetis > Number of patches: 1 > This is an automated relay of the Github pull request: >Fixed null pointer dereference in srv_cleanup_connections() > Patch title(s): >Fixed null pointer dereference in srv_cleanup_connections() > Link: >

[PATCH] yet another spelling patch

2021-01-06 Thread Илья Шипицин
Hello, next patch here :) Ilya From b43294c060bbf69e0b3b6abf17cde684ebf278f0 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 6 Jan 2021 21:20:16 +0500 Subject: [PATCH] CLEANUP: assorted typo fixes in the code and comments This is 15th iteration of typo fixes ---

Re: [PATCH] yet another spelling patch

2021-01-06 Thread Tim Düsterhus
Ilya, Am 06.01.21 um 17:22 schrieb Илья Шипицин: > next patch here :) > @@ -713,7 +713,7 @@ cache_store_http_end(struct stream *s, struct filter > *filter, > /* >* This intends to be used when checking HTTP headers for some >* word=value directive. Return a pointer to the first

[ANNOUNCE] haproxy-2.4-dev5

2021-01-06 Thread Willy Tarreau
Hi, HAProxy 2.4-dev5 was released on 2021/01/06. It added 91 new commits after version 2.4-dev4. This version was mostly focused on new features, but a few bugs were also addressed: - Fred's experimental QUIC code made its entrance! OK OK OK please calm down, it's just a part of the code

Re: [ANNOUNCE] haproxy-2.4-dev5

2021-01-06 Thread Tim Düsterhus
Willy, Am 06.01.21 um 17:43 schrieb Willy Tarreau: > important factor. Finally responses using unknown encodings are not > cached anymore (the list of supported ones is already wide and easy > to extend). > I don't think that is the case (yet). To the best of my knowledge unknown

Re: [PATCH] speling fixes

2021-01-06 Thread Willy Tarreau
Hi Ilya, On Tue, Jan 05, 2021 at 10:12:53PM +0500, ??? wrote: > hello, > > another spelcheck fixes. Applied now, thanks! Willy

SSL session cache block size documentation

2021-01-06 Thread Valters Jansons
Hello everyone, There is a global parameter for SSL session cache block count (tune.ssl.cachesize). Documentation for it currently states: A block uses approximately 200 bytes of memory. This estimate of 200B for each block has been there since version 1.5, and it does not seem to align with

Re: [ANNOUNCE] haproxy-2.4-dev5

2021-01-06 Thread Willy Tarreau
On Wed, Jan 06, 2021 at 06:32:14PM +0100, Tim Düsterhus wrote: > Willy, > > Am 06.01.21 um 17:43 schrieb Willy Tarreau: > > important factor. Finally responses using unknown encodings are not > > cached anymore (the list of supported ones is already wide and easy > > to extend). > >

Re: [PATCH] yet another spelling patch

2021-01-06 Thread Willy Tarreau
On Wed, Jan 06, 2021 at 05:30:56PM +0100, Tim Düsterhus wrote: > > @@ -713,7 +713,7 @@ cache_store_http_end(struct stream *s, struct filter > > *filter, > > /* > >* This intends to be used when checking HTTP headers for some > >* word=value directive. Return a pointer to the first