how to perform 2 healthcheck at once ?

2011-01-19 Thread Илья Шипицин
Dear Sirs, we are running haproxy for SSL balancing using tcp mode clusters. and we are using http checks. actual config is: listen cluster.auth 0.0.0.0:443 mode tcp option tcpka option httpchk GET /ping.ashx HTTP/1.0 balance source server front-1 x.y.z.t:443 check port 80

how to perform 2 healthcheck at once ?

2011-01-19 Thread Илья Шипицин
Dear Sirs, we are running haproxy for SSL balancing using tcp mode clusters. and we are using http checks. actual config is: listen cluster.auth 0.0.0.0:443 mode tcp option tcpka option httpchk GET /ping.ashx HTTP/1.0 balance source server front-1 x.y.z.t:443 check port 80 inter

clang static analysis of haproxy

2016-06-06 Thread Илья Шипицин
Hello, I run scan-build (which is clang static analysis tool) on haproxy git source here's result http://chipitsine.github.io/haproxy-1.7-dev/ there some null pointer dereferences and memory leaks, I think worth looking at them. also, is there some bug tracker ? CI (like travis-ci or

Re: clang static analysis of haproxy

2016-06-06 Thread Илья Шипицин
hould be freed if args[2] is neither "request" nor "response", > otherwise the allocated address is permanently forgotten. > > > On Mon, Jun 6, 2016 at 12:52 PM, Maciej Katafiasz > <mkatafi...@purestorage.com> wrote: > > On 6 June 2016

Re: clang static analysis of haproxy

2016-10-26 Thread Илья Шипицин
2016-10-26 13:26 GMT+05:00 Willy Tarreau : > On Wed, Oct 26, 2016 at 01:15:43PM +0500, ?? wrote: > > as time goes on ... I see, haproxy moved to github ? > > No, it's another fork dedicated to travis that causes some confusion > and that we're trying to smoothly

Re: clang static analysis of haproxy

2016-10-26 Thread Илья Шипицин
as time goes on ... I see, haproxy moved to github ? I like github, especially for PR and travis. should I open a PR on those (not very critial) issues ? and what do you think of travis-ci ? I have some experience in using it, very nice. 2016-06-07 15:20 GMT+05:00 Willy Tarreau :

Re: dynamic configuration via DNS SRV records

2016-12-18 Thread Илья Шипицин
2016-12-19 5:43 GMT+05:00 jerry : > Hi, > > We use haproxy quite a but at soundhound for fronting our various external > and internal services. We are i the process of moving to a container based > deployment model. With kubernetes in particular, it's as easy as editing 1 >

Re: cppcheck finding

2017-09-15 Thread Илья Шипицин
and what about CI ? something like gitlab-ci, travis, jenkins ? I'll invest some efforts in that 2017-09-15 18:04 GMT+05:00 Christopher Faulet <cfau...@haproxy.com>: > Le 15/09/2017 à 08:36, Илья Шипицин a écrit : > >> great, thank for the feedback. >> >

Re: cppcheck finding

2017-09-15 Thread Илья Шипицин
2017-09-15 18:22 GMT+05:00 Christopher Faulet <cfau...@haproxy.com>: > Le 15/09/2017 à 15:07, Илья Шипицин a écrit : > >> and what about CI ? >> >> something like gitlab-ci, travis, jenkins ? I'll invest some efforts in >> that >> >> > No CI. T

Re: cppcheck finding

2017-09-15 Thread Илья Шипицин
2017-09-15 21:29 GMT+05:00 Aleksandar Lazic : > Hi. > > Willy Tarreau wrote on 15.09.2017: > > > On Fri, Sep 15, 2017 at 06:36:20PM +0500, ??? wrote: > >> I'd say, it's chicken and egg situation. Whichever comes first, tests > or CI. > >> if we start a CI with "just

more cppcheck findings

2017-09-15 Thread Илья Шипицин
hello, [contrib/halog/halog.c:1572]: (error) Memory leak: ustat [contrib/mod_defender/defender.c:153]: (error) va_list 'argp' was opened but not closed by va_end(). [contrib/modsecurity/modsec_wrapper.c:109]: (error) va_list 'ap' was opened but not closed by va_end(). [src/51d.c:373]: (error)

Re: cppcheck finding

2017-09-15 Thread Илья Шипицин
great, thank for the feedback. there're few things like that [src/flt_http_comp.c:926] -> [src/flt_http_comp.c:926]: (warning) Either the condition 'txn' is redundant or there is possible null pointer dereference: txn. [src/flt_spoe.c:2765] -> [src/flt_spoe.c:2766]: (warning) Either the

Re: more cppcheck findings

2017-09-18 Thread Илья Шипицин
hello, in case someone is interested, the full list of cppcheck findings git clone http://git.haproxy.org/git/haproxy.git/ cd haproxy script cppcheck --force --enable=all . Ctrl-D grep '(error' typescript grep '(warning' typescript grep '(style' typescript | grep 'The function ' | grep ' is

cppcheck finding

2017-09-14 Thread Илья Шипицин
hello, [src/flt_http_comp.c:926] -> [src/flt_http_comp.c:926]: (warning) Either the condition 'txn' is redundant or there is possible null pointer dereference: txn. should there be && instead of || ? Cheers, Ilya Shipitsin

resolve memory leak in contrib/halog/halog.c

2017-09-22 Thread Илья Шипицин
Hello, [contrib/halog/halog.c:1572]: (error) Memory leak: ustat From e58f1f8989715b2fa0c47c9169985d665c32c487 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 22 Sep 2017 22:33:16 +0500 Subject: [PATCH] BUG/MINOR: contrib/halog: fixing small memory leak Issue was

Re: patch: allow to use any compiler

2017-10-08 Thread Илья Шипицин
2017-10-05 1:01 GMT+05:00 Vincent Bernat <ber...@luffy.cx>: > ❦ 4 octobre 2017 23:49 +0500, Илья Шипицин <chipits...@gmail.com> : > > > while some Makefiles allow to use CC, other just stick to gcc. > > I think we should change to > > > > CC ?= gcc >

Re: another cppcheck finding

2017-10-04 Thread Илья Шипицин
2017-10-04 14:00 GMT+05:00 Christopher Faulet <cfau...@haproxy.com>: > Le 04/10/2017 à 07:49, Илья Шипицин a écrit : > >> >> >> 2017-10-04 9:15 GMT+05:00 Willy Tarreau <w...@1wt.eu <mailto:w...@1wt.eu>>: >> >> Hi Ilya, >> >>

Re: another cppcheck finding

2017-10-03 Thread Илья Шипицин
2017-10-04 9:15 GMT+05:00 Willy Tarreau : > Hi Ilya, > > [also CCing Baptiste] > > On Tue, Oct 03, 2017 at 05:25:17PM +0500, ??? wrote: > > [src/dns.c:2502]: (error) Memory leak: buffer > > > > > > I do not see any "buffer" usage except conditional free. > > should we just

Re: resolve memory leak in contrib/halog/halog.c

2017-10-02 Thread Илья Шипицин
Ack/Nack ? 22 сент. 2017 г. 22:44 пользователь "Илья Шипицин" <chipits...@gmail.com> написал: > Hello, > > > [contrib/halog/halog.c:1572]: (error) Memory leak: ustat >

Re: Experimental / broken HTTP/2 support

2017-10-15 Thread Илья Шипицин
2017-10-15 23:43 GMT+05:00 Willy Tarreau : > On Sun, Oct 15, 2017 at 07:16:51PM +0100, Aaron West wrote: > > Hi Willy, > > > > Sorry to bother you, just a quick question if I may. > > > > Does support for QUIC imply we'd have rudimentary UDP support as well > > or is it only going to

Re: Haproxy segfault error 4 in libc-2.24

2017-10-02 Thread Илья Шипицин
you can try to attach like that https://stackoverflow.com/questions/2152582/start-gdb-using-a-pid (I still think, that core dump is better if possible) 2017-10-02 21:59 GMT+05:00 Marcus Ulbrich : > no chance... error or killing haproxy there is no core file

another cppcheck finding

2017-10-03 Thread Илья Шипицин
hello! [src/dns.c:2502]: (error) Memory leak: buffer I do not see any "buffer" usage except conditional free. should we just remove "buffer" from there ? Cheers, Ilya Shipitsin

Re: patch: allow to use any compiler

2017-10-08 Thread Илья Шипицин
2017-10-08 15:59 GMT+05:00 Vincent Bernat <ber...@luffy.cx>: > ❦ 8 octobre 2017 15:46 +0500, Илья Шипицин <chipits...@gmail.com> : > > >> > while some Makefiles allow to use CC, other just stick to gcc. > >> > I think we should change to > >&g

Re: patch: allow to use any compiler

2017-10-08 Thread Илья Шипицин
2017-10-09 10:10 GMT+05:00 Vincent Bernat <ber...@luffy.cx>: > ❦ 9 octobre 2017 08:49 +0500, Илья Шипицин <chipits...@gmail.com> : > > >> > any particular reason for mixing "CC=gcc" with "CC?=gcc" ? > >> > &g

patch: allow to use any compiler

2017-10-04 Thread Илья Шипицин
Hello, while some Makefiles allow to use CC, other just stick to gcc. I think we should change to CC ?= gcc everywhere Cheers, Ilya Shipitsin From 246341f636d085a4e99bdc9f66b5fa3c7bb2b7d3 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 4 Oct 2017 23:43:05 +0500

Re: patch: allow to use any compiler

2017-10-04 Thread Илья Шипицин
2017-10-05 1:01 GMT+05:00 Vincent Bernat <ber...@luffy.cx>: > ❦ 4 octobre 2017 23:49 +0500, Илья Шипицин <chipits...@gmail.com> : > > > while some Makefiles allow to use CC, other just stick to gcc. > > I think we should change to > > > > CC ?= gcc >

Re: CI/CD HAProxy

2017-12-14 Thread Илья Шипицин
2017-09-16 20:01 GMT+05:00 Aleksandar Lazic : > Hi Olivie. > > Olivier Doucet wrote on 15.09.2017: > > > Hi, > > > > I wanted to open a new thread, as "cppcheck finding" was hijacked with > this CICD / testing ;) > > +1 > > > I think the best is the enemy of the good : why not

Re: Re[2]: CI/CD HAProxy

2017-12-15 Thread Илья Шипицин
2017-12-15 13:07 GMT+05:00 Aleksandar Lazic <al-hapr...@none.at>: > Hi > > -- Originalnachricht -- > Von: "Илья Шипицин" <chipits...@gmail.com> > An: "Aleksandar Lazic" <al-hapr...@none.at> > Cc: "Olivier Doucet" <

Re: HAProxy LB causes server to poll for request data for a long time

2017-11-16 Thread Илья Шипицин
Try proxy_buffering off; proxy_request_buffering off; in nginx On Nov 15, 2017 8:01 PM, "omer kirkagaclioglu" wrote: Hi, I just put a service that has around 400 - 4K http / https mixed requests per second behind haproxy. The endpoint with the highest rate of requests

how to run vtc files?

2018-06-20 Thread Илья Шипицин
hi [ilia@localhost haproxy]$ HAPROXY_PROGRAM=./haproxy varnishtest reg-tests/ssl/h0.vtc top 0.0 extmacro def pwd=/home/ilia/xxx/haproxy top 0.0 extmacro def localhost=127.0.0.1 top 0.0 extmacro def bad_backend=127.0.0.1 36769 top 0.0 extmacro def

Re: centos packages built

2017-12-26 Thread Илья Шипицин
Did you try fedora copr? On Dec 26, 2017 9:50 PM, "Angelo Hongens" wrote: > > FYI, I built haproxy packages for centos6 and centos7, and intend to keep > the repo up to date. I run haproxy on dozens of machines, and I manage them > using spacewalk. So I want recent RPM's ;)

Re: [PR] avoid overriding external prefix

2018-01-03 Thread Илья Шипицин
2018-01-04 2:13 GMT+05:00 Willy Tarreau : > Hi Stephen, > > On Wed, Jan 03, 2018 at 08:33:14PM +0100, PR Bot wrote: > > Dear list! > > > > Author: Stephen > > Number of patches: 1 > > > > This is an automated relay of the Github pull request: >

Re: patch for enabling gitlab-ci

2018-07-14 Thread Илья Шипицин
No interest? On Fri, Jul 13, 2018, 2:58 PM Илья Шипицин wrote: > Hello, > > I created a patch which will allow anyone to build CI > using "CI for external repo" + mirroring on https://gitlab.com > > Cheers, > Ilya Shipitsin >

haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-10 Thread Илья Шипицин
Hello, I had an idea, what if we will run reg-tests with various sanitizers ? for example, https://gitlab.com/chipitsine/haproxy/-/jobs/80667862 (gcc + sanitize-address). can someone confirm a bug there ? "AddressSanitizer: heap-use-after-free on" I'll add more sanitizers later. thanks for

Re: haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-10 Thread Илья Шипицин
just for the record, asan was very easy to enable: https://gitlab.com/chipitsine/haproxy/blob/master/.gitlab-ci.yml вт, 10 июл. 2018 г. в 16:35, Илья Шипицин : > Hello, > > I had an idea, what if we will run reg-tests with various sanitizers ? > > for example, > > https://

how to run reg-tests ?

2018-07-10 Thread Илья Шипицин
HI, I cloned haproxy. built it using: make TARGET=generic USE_OPENSSL=1 when I run tests, it fails: [root@pf0sqjlx haproxy]# VARNISHTEST_PROGRAM=`which varnishtest` HAPROXY_PROGRAM=`pwd`/haproxy make reg-tests top 0.0 extmacro def pwd=/home/ilia/xxx/haproxy top 0.0 extmacro def

Re: how to run reg-tests ?

2018-07-10 Thread Илья Шипицин
I use Fedora 28 if that matters. varnishtest installed from repo (dnf install varnish), it is varnish-5.2.1-4.fc28.x86_64 вт, 10 июл. 2018 г. в 14:58, Илья Шипицин : > HI, > > I cloned haproxy. > built it using: > > make TARGET=generic USE_OPENSSL=1 > > when I run te

Re: how to run reg-tests ?

2018-07-10 Thread Илья Шипицин
nice :) вт, 10 июл. 2018 г. в 15:15, Frederic Lecaille : > Hi, > > > On 07/10/2018 12:02 PM, Илья Шипицин wrote: > > I use Fedora 28 if that matters. > > varnishtest installed from repo (dnf install varnish), it is > > varnish-5.2.1-4.fc28.x86_64 > > >

Re: how to run reg-tests ?

2018-07-10 Thread Илья Шипицин
yahoo! green tests https://gitlab.com/chipitsine/haproxy/-/jobs/80660454 вт, 10 июл. 2018 г. в 15:15, Frederic Lecaille : > Hi, > > > On 07/10/2018 12:02 PM, Илья Шипицин wrote: > > I use Fedora 28 if that matters. > > varnishtest installed from repo (dnf install var

Re: haproxy tests with sanitizers: bug found ? https://gitlab.com/chipitsine/haproxy/-/jobs/80667862

2018-07-11 Thread Илья Шипицин
Thanks, I'll check it out. ср, 11 июл. 2018 г. в 18:20, Frederic Lecaille : > On 07/11/2018 10:41 AM, Frederic Lecaille wrote: > > On 07/10/2018 01:35 PM, Илья Шипицин wrote: > >> Hello, > > > > Hello Ilya, > > > >> I had an idea, what if

how h1_frt_addr is defined during reg tests?

2018-07-11 Thread Илья Шипицин
Hello, I'm playing with reg tests. Sometimes they fail for weird reasons. (for example, fedora 28 on gitlab ci) https://gitlab.com/chipitsine/haproxy/-/jobs/81106855 curl -i -k https://${h1_frt_addr}:${h1_frt_port} became curl -i -k https://::1:38627 which is not correct. but I could not

patch for enabling gitlab-ci

2018-07-13 Thread Илья Шипицин
Hello, I created a patch which will allow anyone to build CI using "CI for external repo" + mirroring on https://gitlab.com Cheers, Ilya Shipitsin commit c75028307a55636f5530671bfcd936162059beed Author: Ilya Shipitsin Date: Fri Jul 13 14:36:55 2018 +0500 FEATURE: gitlab-ci enabled reg

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

2018-07-13 Thread Илья Шипицин
sorry, I did not test it on centos 7 https://gitlab.com/chipitsine/haproxy/-/jobs/81501288 (I could not find out what's that, error message is strange, I'll try to investigate on separate vm) чт, 12 июл. 2018 г. в 14:08, Frederic Lecaille : > This is a patch to fix the issue reported by Ilya

Re: [PATCH] REGTEST/MINOR: Wrong URI syntax.

2018-07-13 Thread Илья Шипицин
пт, 13 июл. 2018 г. в 13:08, Frederic Lecaille : > On 07/13/2018 09:53 AM, Илья Шипицин wrote: > > sorry, I did not test it on centos 7 > > > > https://gitlab.com/chipitsine/haproxy/-/jobs/81501288 > > > > > > (I could not find out what's t

Re: how h1_frt_addr is defined during reg tests?

2018-07-12 Thread Илья Шипицин
yes, it fixed build: https://gitlab.com/chipitsine/haproxy/-/jobs/81225803 чт, 12 июл. 2018 г. в 13:28, Frederic Lecaille : > On 07/11/2018 09:12 PM, Илья Шипицин wrote: > > Hello, > > > > I'm playing with reg tests. Sometimes they fail for weird reasons. > > (for e

haproxy ci (again), gitlab.com ?

2018-07-12 Thread Илья Шипицин
hello, I have the following suggestion 1) I will add .gitlab-ci.yml to the haproxy repo (it will include "centos 7" and "fedora 28" builds, just to cover openssl-1.0.2 and openssl-1.1.0) 2) that .gitlab-ci.yml will run reg tests 3) anyone can follow to https://gitlab.com --> new --> CI for

Re: cppcheck finding

2018-03-14 Thread Илья Шипицин
any action on that ? 2018-03-08 22:29 GMT+05:00 Olivier Houchard : > Hi, > > On Thu, Mar 08, 2018 at 05:44:31PM +0100, Willy Tarreau wrote: > > Hi, > > > > On Wed, Mar 07, 2018 at 03:26:25PM +0500, ??? wrote: > > > Hello, > > > > > > [src/proto_uxst.c:160]:

cppcheck finding

2018-03-15 Thread Илья Шипицин
Hi, [src/51d.c:373]: (error) Invalid number of character '{' when no macros are defined. ?

small cleanup of src/dns.c

2018-03-15 Thread Илья Шипицин
Hello, small issue (no real impact) identified by cppcheck From 733d99f42d93898232bb8c3c953b662ee889c034 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 15 Mar 2018 16:38:38 +0500 Subject: [PATCH] CLEANUP: remove duplicate code in src/dns.c issue was identified by

cppcheck finding

2018-03-07 Thread Илья Шипицин
Hello, [src/proto_uxst.c:160]: (warning) Redundant assignment of 'xfer_sock->next->prev' to itself. is it in purpose ?

format warning cleanup (patch attached)

2018-04-06 Thread Илья Шипицин
Hello, please review the attached patch Ilya Shipitsin From a7f2e5a064c40a5842decc7e053a6e4a4291df33 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 6 Apr 2018 17:06:10 +0500 Subject: [PATCH] MINOR: format warnings cleanup issue detected by cppcheck

Re: format warning cleanup (patch attached)

2018-04-06 Thread Илья Шипицин
well, I was not sure whether to split into several files or not. ok, will split next time :) 2018-04-06 17:32 GMT+05:00 Willy Tarreau : > Hi Ilya, > > On Fri, Apr 06, 2018 at 05:08:20PM +0500, ??? wrote: > > Hello, > > > > please review the attached patch > > thank you,

Re: Haproxy 1.8.4 crashing workers and increased memory usage

2018-04-09 Thread Илья Шипицин
can you try thread sanitizer (in real time)? https://github.com/google/sanitizers/wiki#threadsanitizer I'd like to try myself, however, we do not observe bad things in our environment 2018-04-09 13:24 GMT+05:00 Robin Geuze : > Hey Willy, > > So I made a build this morning

Re: patch (cleanup unused labels)

2018-03-29 Thread Илья Шипицин
oops 2018-03-29 15:31 GMT+05:00 Christopher Faulet <cfau...@haproxy.com>: > Le 29/03/2018 à 12:11, Илья Шипицин a écrit : > >> please review the patch attached >> >> > Hi, > > These labels must not be removed, they are used in calls to the macro > EA

patch (cleanup unused labels)

2018-03-29 Thread Илья Шипицин
please review the patch attached cheers, Ilya Shipitsin From 4ca8083844bc6fa1f06d3e8b85158dba64372f5c Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Thu, 29 Mar 2018 15:09:05 +0500 Subject: [PATCH] MINOR / CLEANUP: src/h1.c: remove unused labels issue detected by

Re: patch: fix build when USE_THREAD is not defined

2018-03-24 Thread Илья Шипицин
in your patch comparision + empty loop will be executed even if USE_THREADS is not defined. not very big performance overhead actually. 2018-03-24 23:02 GMT+05:00 Christopher Faulet <cfau...@haproxy.com>: > Le 24/03/2018 à 13:19, Илья Шипицин a écrit : > >> please rev

Re: patch: fix build when USE_THREAD is not defined

2018-03-26 Thread Илья Шипицин
ok, let's use your approach 2018-03-25 16:52 GMT+05:00 Tim Düsterhus <t...@bastelstu.be>: > Илья, > > Am 24.03.2018 um 19:42 schrieb Илья Шипицин: > > in your patch comparision + empty loop will be executed even if > USE_THREADS > > is not defined. > > not ve

strange cppcheck finding

2018-03-19 Thread Илья Шипицин
(it's master) is it in purpose ? [src/ssl_sock.c:1553]: (warning) Invalid test for overflow 'msg+rec_len

Re: strange cppcheck finding

2018-03-20 Thread Илья Шипицин
"UB" stands for undefined behaviour. that's the reason why cppcheck is unhappy. how do that properly - that's the question :) 2018-03-20 10:48 GMT+05:00 Willy Tarreau : > On Mon, Mar 19, 2018 at 06:55:46PM +0500, ??? wrote: > > (it's master) > > > > is it in purpose ? > > >

cleanup patch submission

2018-03-23 Thread Илья Шипицин
please review attached patch From 7f31259bfc6a86a1beae56c612984c1d4c6b7569 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Fri, 23 Mar 2018 17:41:48 +0500 Subject: [PATCH] CLEANUP: map, stream: remove duplicate code in src/map.c, src/stream.c issue was identified by

compilation is broken without USE_THREAD=1

2018-03-24 Thread Илья Шипицин
hi, src/queue.o: In function `pendconn_redistribute': /home/ilia/haproxy/src/queue.c:272: undefined reference to `thread_want_sync' src/queue.o: In function `pendconn_grab_from_px': /home/ilia/haproxy/src/queue.c:311: undefined reference to `thread_want_sync' src/queue.o: In function

patch: fix build when USE_THREAD is not defined

2018-03-24 Thread Илья Шипицин
please review attached patch From ec9cdfa848d438378919d4f8f2b1cba2a16f3eaa Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 24 Mar 2018 17:17:32 +0500 Subject: [PATCH] MINOR: fix build when USE_THREAD is not defined src/queue.o: In function `pendconn_redistribute':

Re: patch to avoid null pointer dereference

2018-10-01 Thread Илья Шипицин
вт, 2 окт. 2018 г. в 7:06, Willy Tarreau : > Hi Ilya, > > On Sat, Sep 15, 2018 at 12:55:07AM +0500, ??? wrote: > > hi, > > > > please find attached patch > > > > cheers, > > Ilya Shipitsin > > > From 7961bb27597cf529a88da475d3928d6223a88753 Mon Sep 17 00:00:00 2001 > > From: Ilya

Re: Few problems seen in haproxy? (threads, connections).

2018-10-04 Thread Илья Шипицин
> 5. dmesg: no messages. > > With the same system and settings, threads gives 18x lesser RPS than > processes, along with > the other 2 issues given in my mail today. > > > On Thu, Oct 4, 2018 at 12:09 PM Илья Шипицин wrote: > >> haproxy config, nginx config >> non de

Re: Few problems seen in haproxy? (threads, connections).

2018-10-04 Thread Илья Шипицин
with > haproxy configuration file as given in my first mail. Around 60 > backend servers are configured in haproxy. > > 3. Backend servers are 2 core VM's running nginx and serving > a file called "/128", which is 128 bytes in size. > > Let me know if yo

Re: Few problems seen in haproxy? (threads, connections).

2018-10-03 Thread Илья Шипицин
load testing is somewhat good. can you describe an overall setup ? (I want to reproduce and play with it) чт, 4 окт. 2018 г. в 8:16, Krishna Kumar (Engineering) < krishna...@flipkart.com>: > Re-sending in case this mail was missed. To summarise the 3 issues seen: > > 1. Performance drops 18x

patch to avoid null pointer dereference

2018-09-14 Thread Илья Шипицин
hi, please find attached patch cheers, Ilya Shipitsin From 7961bb27597cf529a88da475d3928d6223a88753 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sat, 15 Sep 2018 00:50:05 +0500 Subject: [PATCH] MINOR: src/connection.c: avoid null pointer dereference found by coverity ---

who controls https://github.com/haproxy/haproxy ?

2019-04-12 Thread Илья Шипицин
hello, I wish to enable travis-ci, cirrus-ci builds for github repo I do not see any public member there. who does control it ? thanks!

Re: who controls https://github.com/haproxy/haproxy ?

2019-04-12 Thread Илья Шипицин
yep, I'm going to play in my own fork as well. I will show something soon пт, 12 апр. 2019 г. в 16:50, Tim Düsterhus : > Ilya, > > Am 12.04.19 um 10:54 schrieb Илья Шипицин: > > I wish to enable travis-ci, cirrus-ci builds for github repo > > I do not see any public memb

[PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-16 Thread Илья Шипицин
Hello, let us enable travis-ci on https://github.com/haproxy/haproxy (more builds will be added later) thanks! Ilya Shipitcin From 0eebbedaef858267b637fd0d05751f1e212eae61 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Tue, 16 Apr 2019 23:08:14 +0500 Subject: [PATCH] FEATURE/MEDIUM:

Re: how does ./reg-tests/seamless-reload/b00000.vtc should work ?

2019-04-16 Thread Илья Шипицин
red/green build: https://travis-ci.com/chipitsine/haproxy-1/builds/108555034 вт, 16 апр. 2019 г. в 21:16, Willy Tarreau : > On Tue, Apr 16, 2019 at 05:42:41PM +0200, William Lallemand wrote: > > Hi Ilya, > > > > This is a regression due to recent changes in the master-worker. > > I also found a

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-17 Thread Илья Шипицин
ср, 17 апр. 2019 г. в 07:14, Willy Tarreau : > On Tue, Apr 16, 2019 at 08:31:04PM +0200, Lukas Tribus wrote: > > Hello Ilya , > > > > On Tue, 16 Apr 2019 at 20:18, ??? wrote: > > > > > > Hello, > > > > > > let us enable travis-ci on https://github.com/haproxy/haproxy > > > (more builds

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-17 Thread Илья Шипицин
ср, 17 апр. 2019 г. в 07:29, Willy Tarreau : > Hi Ilya, > > On Tue, Apr 16, 2019 at 11:17:49PM +0500, ??? wrote: > > +env: > > + global: > > +- USE_THREAD=1 > > +- USE_OPENSSL=1 > > +- USE_PCRE=1 > > +- USE_ZLIB=1 > > +- USE_GETADDRINFO=1 > > It's unclear to me how

running reg-test when haproxy is built without USE_OPENSSL

2019-04-17 Thread Илья Шипицин
Hello, when playing with travis-ci build matrix, I see that the following tests fail reg-tests/ssl/* if haproxy is built without ssl. also, I've found that lua tests are guarded with #REQUIRE_OPTIONS=LUA should we guard ssl test in the same way ? thank! Ilya Shipitcin

Re: running reg-test when haproxy is built without USE_OPENSSL

2019-04-17 Thread Илья Шипицин
ср, 17 апр. 2019 г. в 12:14, Frederic Lecaille : > On 4/17/19 9:01 AM, Илья Шипицин wrote: > > Hello, > > Hi, > > > when playing with travis-ci build matrix, I see that the following tests > > fail > > > > reg-tests/ssl/* > > > > if hapro

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-17 Thread Илья Шипицин
btw, we can run lua tests https://travis-ci.com/chipitsine/haproxy-1/builds/108641032 so... how do we want to run lua ? always enabled ? or two builds (with and without lua) ? ср, 17 апр. 2019 г. в 12:43, Илья Шипицин : > I attached v2 patch > > ср, 17 апр. 2019 г. в 12:25, Иль

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-17 Thread Илья Шипицин
I attached v2 patch ср, 17 апр. 2019 г. в 12:25, Илья Шипицин : > > > ср, 17 апр. 2019 г. в 12:18, Frederic Lecaille : > >> On 4/16/19 8:17 PM, Илья Шипицин wrote: >> > + - make CC=$CC V=1 TARGET=$TARGET >> > + - export PATH=${PATH}:${PWD}/VTest >> &

exclude some reg-tests if no ssl or pcre is enabled

2019-04-17 Thread Илья Шипицин
hello, when playing with travis-ci, I've found that ssl, pcre tests are executed even if haproxy is built without such features. thanks! Ilya Shipitcin From 5e786e8bc2a12ad4b53e3fdbfc3464738fd4e6df Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Wed, 17 Apr 2019 12:19:56 +0500 Subject:

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-17 Thread Илья Шипицин
ср, 17 апр. 2019 г. в 12:18, Frederic Lecaille : > On 4/16/19 8:17 PM, Илья Шипицин wrote: > > + - make CC=$CC V=1 TARGET=$TARGET > > + - export PATH=${PATH}:${PWD}/VTest > > + - export VTEST_PROGRAM="VTest/vtest -v" # "VTest/vtest -v" > &g

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-23 Thread Илья Шипицин
вт, 23 апр. 2019 г. в 14:50, Willy Tarreau : > Hi Tim, > > On Tue, Apr 23, 2019 at 11:28:22AM +0200, Tim Düsterhus wrote: > > No real management necessary. > (...) > > Ideally you should not notice anything: It means no one commited bad > > code. It might need some adjustments in the beginning,

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
yep, I'm going to invest some time in building openssl matrix on travis-ci, i.e. openssl-1.0, 1.0.2, 1.1.1, libressl, ... вт, 23 апр. 2019 г. в 22:31, Willy Tarreau : > On Tue, Apr 23, 2019 at 10:11:09PM +0500, ??? wrote: > > I want to bisect in order to find offending commit. > > we've

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
-ci.com/haproxy/haproxy/builds/109289462 вт, 23 апр. 2019 г. в 22:11, Илья Шипицин : > I want to bisect in order to find offending commit. > we've got regression. it need to be fixed, no need to mark it as "allowed > failure" > > вт, 23 апр. 2019 г. в 22:00, Willy Tarr

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
let us wait for a while and do not enable "allow failures". вт, 23 апр. 2019 г. в 20:24, Willy Tarreau : > On Tue, Apr 23, 2019 at 04:41:44PM +0200, Tim Düsterhus wrote: > > List, > > > > Am 23.04.19 um 16:40 schrieb Tim Duesterhus: > > > [...] > > > > Sorry for the noise. This v2 only differs

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
this particular regression is reproduced on my fedora laptop, which is openssl-1.1.X вт, 23 апр. 2019 г. в 22:31, Willy Tarreau : > On Tue, Apr 23, 2019 at 10:11:09PM +0500, ??? wrote: > > I want to bisect in order to find offending commit. > > we've got regression. it need to be fixed,

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
I want to bisect in order to find offending commit. we've got regression. it need to be fixed, no need to mark it as "allowed failure" вт, 23 апр. 2019 г. в 22:00, Willy Tarreau : > On Tue, Apr 23, 2019 at 09:20:52PM +0500, ??? wrote: > > let us wait for a while and do not enable "allow

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-24 Thread Илья Шипицин
here's "v2" ср, 24 апр. 2019 г. в 18:56, Илья Шипицин : > I can test myself and send "v2" in couple of hours if you do not mind > > ср, 24 апр. 2019 г. в 18:48, Tim Düsterhus : > >> Willy, >> Ilya, >> >> I'm not in the office today and can

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-24 Thread Илья Шипицин
, 24 апр. 2019 г. в 19:21, Илья Шипицин : > here's "v2" > > ср, 24 апр. 2019 г. в 18:56, Илья Шипицин : > >> I can test myself and send "v2" in couple of hours if you do not mind >> >> ср, 24 апр. 2019 г. в 18:48, Tim Düsterhus : >> >>

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-24 Thread Илья Шипицин
gh tons of logs. The > details can then be found collapsed at the bottom. > > Best regards > Tim Düsterhus > > Am 24.04.2019 16:59 schrieb Илья Шипицин : > > Tim, I'm bit curious about > > after_failure: > - | > for folder in ${TMPDIR:-/tmp}/*regtest*/vtc.*; do >

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-25 Thread Илья Шипицин
Yes, I did have a look as well, those failures did not look like something we would wish to ignore )) Also, I'd suggest to extend osx build to include more features. I will do it soon On Thu, Apr 25, 2019, 12:00 PM Willy Tarreau wrote: > On Thu, Apr 25, 2019 at 08:26:37AM +0200, Willy Tarreau

how does ./reg-tests/seamless-reload/b00000.vtc should work ?

2019-04-16 Thread Илья Шипицин
Hello, I'm trying to get travis-ci working. currently I stuck with https://travis-ci.com/chipitsine/haproxy-1/jobs/193239855 can you help me with that issue ? Thanks, Ilya Shipitcin

bad guarding of reg-tests

2019-04-16 Thread Илья Шипицин
hello, when I played with travis-ci, I've found the following 1) travis-ci uses ubuntu trusty, which comes with openssl-1.0.1, obviously no ALPN. some reg-tests expect ALPN in curl 2) tests do not check whether haproxy is built with USE_PCRE=1 (but they assume that) thanks, Ilya Shipitcin

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-23 Thread Илья Шипицин
вт, 23 апр. 2019 г. в 23:25, Willy Tarreau : > On Tue, Apr 23, 2019 at 10:31:05PM +0500, ??? wrote: > > Hello, Baptise! > > > > we have enabled travis-ci builds on haproxy master branch. seems we have > a > > regression here: > > > > >

how to specify CFLAGS ?

2019-04-24 Thread Илья Шипицин
Hello, I'm going to use various sanitizers, for example CFLAGS="-fsanitize=address" I'm looking for preferred way to set additional CFLAGS, am I right that it is something like ADDINC="-fsanitize=address" ? any other way ? thanks! Ilya Shipitsin

Re: [PATCH v2] MINOR: travis: Extend .travis.yml

2019-04-24 Thread Илья Шипицин
I'd accept "Extend .travis.yml" patch except "allow_failures" Tim, do you mind to send "v2" ? ср, 24 апр. 2019 г. в 17:45, Willy Tarreau : > Hi Ilya, > > On Tue, Apr 23, 2019 at 09:37:27PM +0200, Willy Tarreau wrote: > > On Wed, Apr 24, 2019 at 12:30:36AM +0500, ??? wrote: > > > > >

Re: how to specify CFLAGS ?

2019-04-24 Thread Илья Шипицин
I've managed to pass sanitizer flags )) I will add something like that to travis-ci later *** h10.1 debug|==19083==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00a8cda8 at pc 0x006efec0 bp 0x7ffc78cfc990 sp 0x7ffc78cfc988 *** h10.1 debug|READ of size 8 at

Re: [PATCH] FEATURE/MEDIUM: enable travis-ci builds

2019-04-22 Thread Илья Шипицин
I can enable travis-ci by myself if you can temporarily grant me an access to github repo пт, 19 апр. 2019 г. в 01:03, Илья Шипицин : > > > чт, 18 апр. 2019 г. в 21:51, Илья Шипицин : > >> >> >> чт, 18 апр. 2019 г. в 21:45, Willy Tarreau : >> >>> H

PATCH: fix typo

2019-04-30 Thread Илья Шипицин
Hello, typo was found by cppcheck thank! Ilya Shipitsin From 62c6b78843e9c1b6f829872a54175f68332a2859 Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Tue, 30 Apr 2019 21:21:28 +0500 Subject: [PATCH] MINOR: fix typo "src" instead of "srv" --- src/server.c | 2 +- 1 file changed, 1

Re: reg-tests fail on FreeBSD 12.0

2019-04-29 Thread Илья Шипицин
un freebsd builds in "build only mode", no reg tests 4) ... пн, 29 апр. 2019 г. в 18:36, Frederic Lecaille : > On 4/29/19 2:18 PM, Frederic Lecaille wrote: > > On 4/27/19 1:28 AM, Илья Шипицин wrote: > >> please have a look > >> > >> > >> bu

reg-tests fail on FreeBSD 12.0

2019-04-26 Thread Илья Шипицин
please have a look build script: https://github.com/chipitsine/haproxy-1/commit/6739f36463dc9e82eb65a9fa8353a42128403f0c build log (error): https://api.cirrus-ci.com/v1/task/5196617547251712/logs/main.log any idea ? thanks! Ilya Shipicin

fix LibreSSL builds

2019-04-27 Thread Илья Шипицин
Hi, I tested the following patch on LibreSSL-2.7.5, 2.8.3, 2.9.1 thanks! Ilya Shipitcin From 12c3a7b0eac4bab73864869bf8fcb365c9ba06ef Mon Sep 17 00:00:00 2001 From: Ilya Shipitsin Date: Sun, 28 Apr 2019 00:00:16 +0500 Subject: [PATCH] BUILD: add defines to support LibreSSL tested on

  1   2   >